merge tests

Author: mydea

dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-lcp/test.ts

@@ -5,21 +5,16 @@ import type { Event } from '@sentry/core';
 import { sentryTest } from '../../../../utils/fixtures';
 import { getFirstSentryEnvelopeRequest, shouldSkipTracingTest } from '../../../../utils/helpers';
 
-/*
-  Because we "serve" the html test page as a static file, all requests for the image
-  are considered 3rd party requests. So the LCP value we obtain for the image is also
-  considered a 3rd party LCP value, meaning `renderTime` is only set if we also
-  return the `Timing-Allow-Origin` header.
-*/
-
-sentryTest('captures LCP vitals with element details.', async ({ browserName, getLocalTestUrl, page }) => {
+sentryTest('captures LCP vitals with element details', async ({ browserName, getLocalTestUrl, page }) => {
   if (shouldSkipTracingTest() || browserName !== 'chromium') {
     sentryTest.skip();
   }
 
   page.route('**', route => route.continue());
   page.route('**/my/image.png', async (route: Route) => {
-    return route.fulfill({ path: `${__dirname}/assets/sentry-logo-600x179.png` });
+    return route.fulfill({
+      path: `${__dirname}/assets/sentry-logo-600x179.png`,
+    });
   });
 
   const url = await getLocalTestUrl({ testDir: __dirname });
@@ -31,40 +26,8 @@ sentryTest('captures LCP vitals with element details.', async ({ browserName, ge
   expect(eventData.contexts?.trace?.data?.['lcp.element'].startsWith('body >')).toBe(true);
   expect(eventData.contexts?.trace?.data?.['lcp.size']).toBeGreaterThan(0);
   expect(eventData.contexts?.trace?.data?.['lcp.loadTime']).toBeGreaterThan(0);
-
   expect(eventData.contexts?.trace?.data?.['lcp.renderTime']).toBeGreaterThan(0);
 
-  // The LCP value should be the renderTime
+  // The LCP value should be the renderTime because the renderTime is set
   expect(eventData.measurements?.lcp?.value).toBeCloseTo(eventData.contexts?.trace?.data?.['lcp.renderTime']);
 });
-
-sentryTest(
-  'captures LCP renderTime when returning Timing-Allow-Origin header.',
-  async ({ browserName, getLocalTestUrl, page }) => {
-    if (shouldSkipTracingTest() || browserName !== 'chromium') {
-      sentryTest.skip();
-    }
-
-    page.route('**', route => route.continue());
-    page.route('**/my/image.png', async (route: Route) => {
-      return route.fulfill({
-        path: `${__dirname}/assets/sentry-logo-600x179.png`,
-        headers: { 'Timing-Allow-Origin': '*' },
-      });
-    });
-
-    const url = await getLocalTestUrl({ testDir: __dirname });
-    const [eventData] = await Promise.all([getFirstSentryEnvelopeRequest<Event>(page), page.goto(url)]);
-
-    expect(eventData.measurements).toBeDefined();
-    expect(eventData.measurements?.lcp?.value).toBeDefined();
-
-    expect(eventData.contexts?.trace?.data?.['lcp.element'].startsWith('body >')).toBe(true);
-    expect(eventData.contexts?.trace?.data?.['lcp.size']).toBeGreaterThan(0);
-    expect(eventData.contexts?.trace?.data?.['lcp.loadTime']).toBeGreaterThan(0);
-    expect(eventData.contexts?.trace?.data?.['lcp.renderTime']).toBeGreaterThan(0);
-
-    // The LCP value should be the renderTime because the renderTime is set
-    expect(eventData.measurements?.lcp?.value).toBeCloseTo(eventData.contexts?.trace?.data?.['lcp.renderTime']);
-  },
-);