Skip to content

Commit fe6711f

Browse files
committed
Clean build output before running test
1 parent 7b64cb2 commit fe6711f

File tree

1 file changed

+7
-2
lines changed
  • dev-packages/e2e-tests/test-applications/solidstart

1 file changed

+7
-2
lines changed

dev-packages/e2e-tests/test-applications/solidstart/package.json

+7-2
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,19 @@
33
"version": "0.0.0",
44
"scripts": {
55
"clean": "pnpx rimraf node_modules pnpm-lock.yaml .vinxi .output",
6+
"clean:build": "pnpx rimraf .vinxi .output",
67
"dev": "NODE_OPTIONS='--import ./src/instrument.server.mjs' vinxi dev",
78
"build": "vinxi build",
89
"//": [
910
"We are using `vinxi dev` to start the server because `vinxi start` is experimental and ",
1011
"doesn't correctly resolve modules for @sentry/solidstart/solidrouter.",
11-
"This is currently not an issue outside of our repo. See: https://github.com/nksaraf/vinxi/issues/177"
12+
"This is currently not an issue outside of our repo. See: https://github.com/nksaraf/vinxi/issues/177",
13+
"We run the build command to ensure building succeeds. However, keeping",
14+
"build output around slows down the vite dev server when using `@sentry/vite-plugin` so we clear it out",
15+
"before actually running the tests.",
16+
"Cleaning the build output should be removed once we can use `vinxi start`."
1217
],
13-
"preview": "HOST=localhost PORT=3030 NODE_OPTIONS='--import ./src/instrument.server.mjs' vinxi dev",
18+
"preview": "pnpm clean:build && HOST=localhost PORT=3030 NODE_OPTIONS='--import ./src/instrument.server.mjs' vinxi dev",
1419
"start": "HOST=localhost PORT=3030 NODE_OPTIONS='--import ./src/instrument.server.mjs' vinxi start",
1520
"test:prod": "TEST_ENV=production playwright test",
1621
"test:build": "pnpm install && npx playwright install && pnpm build",

0 commit comments

Comments
 (0)