fix: don't log if Debug=$false (#75)

vaind · web-flow · commit ff7d9114a01b · 2025-01-23T11:57:27.000+01:00
* fix: don't log on windows-powershell if debug=false

* chore: changelog

* Update CHANGELOG.md
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+### Fixes
+
+- Don't log debug messages if `-Debug` wasn't set ([#75](https://github.com/getsentry/sentry-powershell/pull/75))
+
 ### Dependencies
 
 - Bump Dotnet SDK from v4.12.1 to v4.13.0 ([#69](https://github.com/getsentry/sentry-powershell/pull/69))
diff --git a/modules/Sentry/private/DiagnosticLogger.ps1 b/modules/Sentry/private/DiagnosticLogger.ps1
@@ -53,7 +53,12 @@ class DiagnosticLogger : Sentry.Extensibility.IDiagnosticLogger
             {
                 # Workaround for Windows Powershell issue of halting and asking for user confirmation.
                 # see https://github.com/PowerShell/PowerShell/issues/5148
-                $DebugPreference = 'Continue'
+                if ($global:PSVersionTable.PSEdition -eq 'Desktop') {
+                    $pref = Get-Variable DebugPreference
+                    if ($pref.value -eq "Inquire") {
+                        $DebugPreference = 'Continue'
+                    }
+                }
 
                 Write-Debug $message
             }

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,12 @@ class DiagnosticLogger : Sentry.Extensibility.IDiagnosticLogger`
`53`	`53`	`{`
`54`	`54`	`# Workaround for Windows Powershell issue of halting and asking for user confirmation.`
`55`	`55`	`# see https://github.com/PowerShell/PowerShell/issues/5148`
`56`		`- $DebugPreference = 'Continue'`
	`56`	`+ if ($global:PSVersionTable.PSEdition -eq 'Desktop') {`
	`57`	`+ $pref = Get-Variable DebugPreference`
	`58`	`+ if ($pref.value -eq "Inquire") {`
	`59`	`+ $DebugPreference = 'Continue'`
	`60`	`+ }`
	`61`	`+ }`
`57`	`62`
`58`	`63`	`Write-Debug $message`
`59`	`64`	`}`