Skip to content

Commit 32ed864

Browse files
authored
feat(ui): Reword javascript session tooltips (#23530)
1 parent 868a01a commit 32ed864

File tree

2 files changed

+20
-18
lines changed

2 files changed

+20
-18
lines changed

src/sentry/static/sentry/app/views/releases/utils/sessionTerm.tsx

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,10 @@ export const sessionTerm = {
2727
// This should never be used directly (except in tests)
2828
export const commonTermsDescription = {
2929
[SessionTerm.CRASHES]: t('Number of sessions with a crashed state'),
30-
[SessionTerm.CRASH_FREE_USERS]: t('Number of unique users with non-crashed sessions'),
31-
[SessionTerm.CRASH_FREE_SESSIONS]: t('Number of non-crashed sessions'),
30+
[SessionTerm.CRASH_FREE_USERS]: t(
31+
'Percentage of unique users with non-crashed sessions'
32+
),
33+
[SessionTerm.CRASH_FREE_SESSIONS]: t('Percentage of non-crashed sessions'),
3234
[SessionTerm.STABILITY]: t(
3335
'The percentage of crash free sessions and how it has changed since the last period.'
3436
),
@@ -39,7 +41,7 @@ export const mobileTermsDescription = {
3941
[SessionTerm.CRASHED]: t(
4042
'The process was terminated due to an unhandled exception or a request to the server that ended with an error'
4143
),
42-
[SessionTerm.CRASH_FREE_SESSIONS]: t('Number of unique sessions that did not crash'),
44+
[SessionTerm.CRASH_FREE_SESSIONS]: t('Percentage of non-crashed sessions'),
4345
[SessionTerm.ABNORMAL]: t(
4446
'An unknown session exit. Like due to loss of power or killed by the operating system'
4547
),
@@ -112,15 +114,15 @@ function getTermDescriptions(platform: PlatformKey | null) {
112114
return {
113115
...commonTermsDescription,
114116
[SessionTerm.CRASHED]: t(
115-
"During the session an error with mechanism.handled===false occurred calling the 'onerror' on 'unhandledrejection' handler"
117+
'During the session an unhandled global error/promise rejection occurred.'
116118
),
117-
[SessionTerm.ABNORMAL]: t('Non applicable for Javascript'),
118-
[SessionTerm.HEALTHY]: t('No errors were captured during session life-time'),
119+
[SessionTerm.ABNORMAL]: t('Non applicable for Javascript.'),
120+
[SessionTerm.HEALTHY]: t('No errors were captured during session life-time.'),
119121
[SessionTerm.ERRORED]: t(
120-
'During the session at least one error occurred that did not bubble up to the global handler. The application loading process did not crash'
122+
'During the session at least one handled error occurred.'
121123
),
122124
[SessionTerm.UNHANDLED]:
123-
"An error was captured by the global 'onerror' or 'onunhandledrejection' handler",
125+
"An error was captured by the global 'onerror' or 'onunhandledrejection' handler.",
124126
};
125127
case 'apple-ios':
126128
case 'minidump':

tests/js/spec/views/releases/utils/sessionTerm.spec.tsx

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -488,7 +488,7 @@ describe('Release Health Session Term', function () {
488488
'node-express'
489489
);
490490
expect(crashedSessionTerm).toEqual(
491-
"During the session an error with mechanism.handled===false occurred calling the 'onerror' on 'unhandledrejection' handler"
491+
'During the session an unhandled global error/promise rejection occurred.'
492492
);
493493

494494
// Crash Free Users
@@ -510,15 +510,15 @@ describe('Release Health Session Term', function () {
510510
SessionTerm.ABNORMAL,
511511
'node-express'
512512
);
513-
expect(abnormalSessionTerm).toEqual('Non applicable for Javascript');
513+
expect(abnormalSessionTerm).toEqual('Non applicable for Javascript.');
514514

515515
// Healthy
516516
const healthySessionTerm = getSessionTermDescription(
517517
SessionTerm.HEALTHY,
518518
'node-express'
519519
);
520520
expect(healthySessionTerm).toEqual(
521-
'No errors were captured during session life-time'
521+
'No errors were captured during session life-time.'
522522
);
523523

524524
// Errored
@@ -527,7 +527,7 @@ describe('Release Health Session Term', function () {
527527
'node-express'
528528
);
529529
expect(erroredSessionTerm).toEqual(
530-
'During the session at least one error occurred that did not bubble up to the global handler. The application loading process did not crash'
530+
'During the session at least one handled error occurred.'
531531
);
532532

533533
// Unhandled
@@ -536,7 +536,7 @@ describe('Release Health Session Term', function () {
536536
'node-express'
537537
);
538538
expect(unhandledSessionTerm).toEqual(
539-
"An error was captured by the global 'onerror' or 'onunhandledrejection' handler"
539+
"An error was captured by the global 'onerror' or 'onunhandledrejection' handler."
540540
);
541541
});
542542

@@ -554,7 +554,7 @@ describe('Release Health Session Term', function () {
554554
'javascript'
555555
);
556556
expect(crashedSessionTerm).toEqual(
557-
"During the session an error with mechanism.handled===false occurred calling the 'onerror' on 'unhandledrejection' handler"
557+
'During the session an unhandled global error/promise rejection occurred.'
558558
);
559559

560560
// Crash Free Users
@@ -576,15 +576,15 @@ describe('Release Health Session Term', function () {
576576
SessionTerm.ABNORMAL,
577577
'javascript'
578578
);
579-
expect(abnormalSessionTerm).toEqual('Non applicable for Javascript');
579+
expect(abnormalSessionTerm).toEqual('Non applicable for Javascript.');
580580

581581
// Healthy
582582
const healthySessionTerm = getSessionTermDescription(
583583
SessionTerm.HEALTHY,
584584
'javascript'
585585
);
586586
expect(healthySessionTerm).toEqual(
587-
'No errors were captured during session life-time'
587+
'No errors were captured during session life-time.'
588588
);
589589

590590
// Errored
@@ -593,7 +593,7 @@ describe('Release Health Session Term', function () {
593593
'javascript'
594594
);
595595
expect(erroredSessionTerm).toEqual(
596-
'During the session at least one error occurred that did not bubble up to the global handler. The application loading process did not crash'
596+
'During the session at least one handled error occurred.'
597597
);
598598

599599
// Unhandled
@@ -602,7 +602,7 @@ describe('Release Health Session Term', function () {
602602
'javascript'
603603
);
604604
expect(unhandledSessionTerm).toEqual(
605-
"An error was captured by the global 'onerror' or 'onunhandledrejection' handler"
605+
"An error was captured by the global 'onerror' or 'onunhandledrejection' handler."
606606
);
607607
});
608608

0 commit comments

Comments
 (0)