File tree Expand file tree Collapse file tree 1 file changed +5
-1
lines changed
src/sentry/deletions/defaults Expand file tree Collapse file tree 1 file changed +5
-1
lines changed Original file line number Diff line number Diff line change @@ -175,13 +175,17 @@ def chunk(self) -> bool:
175
175
if the deletion has completed and if it needs to be called again."""
176
176
events = self .get_unfetched_events ()
177
177
if events :
178
+ # Ideally, in some cases, we should also delete the associated event from the Nodestore.
179
+ # In the occurrence_consumer [1] we sometimes create a new event but it's hard in post-ingestion to distinguish between
180
+ # a created event and an existing one.
181
+ # https://github.com/getsentry/sentry/blob/a86b9b672709bc9c4558cffb2c825965b8cee0d1/src/sentry/issues/occurrence_consumer.py#L324-L339
178
182
self .delete_events_from_nodestore (events )
179
183
# This value will be used in the next call to chunk
180
184
self .last_event = events [- 1 ]
181
185
# As long as it returns True the task will keep iterating
182
186
return True
183
187
else :
184
- # Now that all events have been deleted from the eventstore, we can delete the events from snuba
188
+ # Now that all events have been deleted from the eventstore, we can delete the occurrences from Snuba
185
189
self .delete_events_from_snuba ()
186
190
return False
187
191
You can’t perform that action at this time.
0 commit comments