Skip to content

Commit 999f341

Browse files
authored
Apply suggestions from code review
1 parent e75245f commit 999f341

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

src/config-utils.test.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2504,9 +2504,6 @@ test("no generateRegistries when CLI is too old", async (t) => {
25042504
undefined,
25052505
"'registries' input is not supported on CodeQL versions less than 2.10.4."
25062506
);
2507-
2508-
// t.is(registriesAuthTokens, undefined);
2509-
// t.is(qlconfigFile, undefined);
25102507
});
25112508
});
25122509
test("no generateRegistries when registries is undefined", async (t) => {

src/init.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,8 @@ export async function runInit(
111111

112112
try {
113113
if (await codeQlVersionAbove(codeql, CODEQL_VERSION_NEW_TRACING)) {
114-
// Only create the qlconfig file if we haven't already created it.
114+
// When parsing the codeql config in the CLI, we have not yet created the qlconfig file.
115+
// So, create it now.
115116
// If we are parsing the config file in the Action, then we already created the qlconfig
116117
// file in `configUtils.generateRegistries`.
117118
let registriesAuthTokens: string | undefined;

0 commit comments

Comments
 (0)