M0-2-1: rename shared queries

Author: knewbury01

c/common/test/rules/donotpassaliasedpointertorestrictqualifiedparam_shared/DoNotPassAliasedPointerToRestrictQualifiedParam_Shared.expected renamed to c/common/test/rules/donotpassaliasedpointertorestrictqualifiedparamshared/DoNotPassAliasedPointerToRestrictQualifiedParamShared.expected

@@ -0,0 +1 @@
+cpp/common/test/rules/donotpassaliasedpointertorestrictqualifiedparamshared/DoNotPassAliasedPointerToRestrictQualifiedParamShared.ql

c/common/test/rules/donotpassaliasedpointertorestrictqualifiedparam_shared/DoNotPassAliasedPointerToRestrictQualifiedParam_Shared.ql renamed to c/common/test/rules/donotpassaliasedpointertorestrictqualifiedparamshared/DoNotPassAliasedPointerToRestrictQualifiedParamShared.ql

@@ -7,7 +7,7 @@ newtype RepresentationQuery =
   TBitFieldsShallBeUsedOnlyWhenInterfacingToHardwareOrConformingToCommunicationProtocolsQuery() or
   TAuditPossibleHardwareInterfaceDueToBitFieldUsageInDataTypeDefinitionQuery() or
   TObjectAssignedToAnOverlappingObjectQuery() or
-  TDoNotPassAliasedPointerToRestrictQualifiedParamQuery() or
+  TDoNotPassAliasedPointerToParamQuery() or
   TUnderlyingBitRepresentationsOfFloatingPointValuesUsedQuery() or
   TNamedBitFieldsWithSignedIntegerTypeShallHaveALengthOfMoreThanOneBitQuery() or
   TMemsetUsedToAccessObjectRepresentationQuery() or
@@ -43,11 +43,11 @@ predicate isRepresentationQueryMetadata(Query query, string queryId, string rule
   category = "required"
   or
   query =
-    // `Query` instance for the `doNotPassAliasedPointerToRestrictQualifiedParam` query
-    RepresentationPackage::doNotPassAliasedPointerToRestrictQualifiedParamQuery() and
+    // `Query` instance for the `doNotPassAliasedPointerToParam` query
+    RepresentationPackage::doNotPassAliasedPointerToParamQuery() and
   queryId =
-    // `@id` for the `doNotPassAliasedPointerToRestrictQualifiedParam` query
-    "cpp/autosar/do-not-pass-aliased-pointer-to-restrict-qualified-param" and
+    // `@id` for the `doNotPassAliasedPointerToParam` query
+    "cpp/autosar/do-not-pass-aliased-pointer-to-param" and
   ruleId = "M0-2-1" and
   category = "required"
   or
@@ -119,11 +119,11 @@ module RepresentationPackage {
       TQueryCPP(TRepresentationPackageQuery(TObjectAssignedToAnOverlappingObjectQuery()))
   }
 
-  Query doNotPassAliasedPointerToRestrictQualifiedParamQuery() {
+  Query doNotPassAliasedPointerToParamQuery() {
     //autogenerate `Query` type
     result =
-      // `Query` type for `doNotPassAliasedPointerToRestrictQualifiedParam` query
-      TQueryCPP(TRepresentationPackageQuery(TDoNotPassAliasedPointerToRestrictQualifiedParamQuery()))
+      // `Query` type for `doNotPassAliasedPointerToParam` query
+      TQueryCPP(TRepresentationPackageQuery(TDoNotPassAliasedPointerToParamQuery()))
   }
 
   Query underlyingBitRepresentationsOfFloatingPointValuesUsedQuery() {

c/common/test/rules/donotpassaliasedpointertorestrictqualifiedparam_shared/test.c renamed to c/common/test/rules/donotpassaliasedpointertorestrictqualifiedparamshared/test.c

@@ -0,0 +1,15 @@
+/**
+ * Provides a library which includes a `problems` predicate for reporting....
+ */
+
+import cpp
+import codingstandards.cpp.Customizations
+import codingstandards.cpp.Exclusions
+
+abstract class DoNotPassAliasedPointerToRestrictQualifiedParamSharedSharedQuery extends Query { }
+
+Query getQuery() { result instanceof DoNotPassAliasedPointerToRestrictQualifiedParamSharedSharedQuery }
+
+query predicate problems(Element e, string message) {
+not isExcluded(e, getQuery()) and message = "<replace with problem alert message for >"
+}

cpp/autosar/src/rules/M0-2-1/DoNotPassAliasedPointerToRestrictQualifiedParam.ql renamed to cpp/autosar/src/rules/M0-2-1/DoNotPassAliasedPointerToParam.ql

@@ -72,7 +72,7 @@
           "precision": "medium",
           "severity": "error",
           "short_name": "DoNotPassAliasedPointerToRestrictQualifiedParam",
-          "shared_implementation_short_name": "DoNotPassAliasedPointerToRestrictQualifiedParam_Shared",
+          "shared_implementation_short_name": "DoNotPassAliasedPointerToRestrictQualifiedParamShared",
           "tags": [
             "correctness"
           ]

cpp/autosar/test/rules/M0-2-1/DoNotPassAliasedPointerToParam.testref

@@ -55,13 +55,13 @@
           ]
         },
         {
-          "description": "Passing an aliased pointer to a conceptually restrict-qualified parameter is undefined behavior.",
+          "description": "Passing a aliased pointers as parameters of certain functions is undefined behavior.",
           "kind": "problem",
           "name": "Do not pass aliased pointers as parameters of functions where it is undefined behaviour for those pointers to overlap",
           "precision": "medium",
           "severity": "error",
-          "short_name": "DoNotPassAliasedPointerToRestrictQualifiedParam",
-          "shared_implementation_short_name": "DoNotPassAliasedPointerToRestrictQualifiedParam_Shared",
+          "short_name": "DoNotPassAliasedPointerToParam",
+          "shared_implementation_short_name": "DoNotPassAliasedPointerToRestrictQualifiedParamShared",
           "tags": [
             "correctness"
           ]