Skip to content

Commit 0728ece

Browse files
committed
Python: Highlight that import problem is not just a relative problem
1 parent 1ca1953 commit 0728ece

File tree

4 files changed

+21
-0
lines changed

4 files changed

+21
-0
lines changed

python/ql/test/experimental/dataflow/typetracking_imports/highlight_problem.expected

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,7 @@
33
| pkg/alias_problem.py:0:0:0:0 | Module pkg.alias_problem | pkg/alias_problem.py:2:1:2:20 | GSSA Variable foo | use to normal exit |
44
| pkg/alias_problem_fixed.py:0:0:0:0 | Module pkg.alias_problem_fixed | pkg/alias_problem_fixed.py:0:0:0:0 | GSSA Variable foo | no use to normal exit |
55
| pkg/alias_problem_fixed.py:0:0:0:0 | Module pkg.alias_problem_fixed | pkg/alias_problem_fixed.py:3:22:3:24 | GSSA Variable foo | use to normal exit |
6+
| pkg/problem_absolute_import.py:0:0:0:0 | Module pkg.problem_absolute_import | pkg/problem_absolute_import.py:1:25:1:27 | GSSA Variable foo | no use to normal exit |
7+
| pkg/problem_absolute_import.py:0:0:0:0 | Module pkg.problem_absolute_import | pkg/problem_absolute_import.py:2:1:2:23 | GSSA Variable foo | use to normal exit |
8+
| pkg/works_absolute_import.py:0:0:0:0 | Module pkg.works_absolute_import | pkg/works_absolute_import.py:0:0:0:0 | GSSA Variable foo | no use to normal exit |
9+
| pkg/works_absolute_import.py:0:0:0:0 | Module pkg.works_absolute_import | pkg/works_absolute_import.py:2:25:2:27 | GSSA Variable foo | use to normal exit |
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
from pkg.foo_def import foo # $ tracked
2+
from pkg.other import *

python/ql/test/experimental/dataflow/typetracking_imports/pkg/use.py

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,3 +31,16 @@ def test_alias_only_direct():
3131
print(foo) # $ tracked
3232

3333
test_alias_only_direct()
34+
35+
36+
def test_problem_absolute_import():
37+
from pkg.problem_absolute_import import foo # $ MISSING: tracked
38+
print(foo) # $ MISSING: tracked
39+
40+
test_problem_absolute_import()
41+
42+
def test_works_absolute_import():
43+
from pkg.works_absolute_import import foo # $ tracked
44+
print(foo) # $ tracked
45+
46+
test_works_absolute_import()
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
from pkg.other import *
2+
from pkg.foo_def import foo # $ tracked

0 commit comments

Comments
 (0)