Skip to content

Commit 11abbf8

Browse files
committed
Now nextUrl is of type parameter and loosen the restriction for NextAppRouteHandler
1 parent 92e4f11 commit 11abbf8

File tree

1 file changed

+10
-16
lines changed
  • javascript/ql/lib/semmle/javascript/frameworks

1 file changed

+10
-16
lines changed

javascript/ql/lib/semmle/javascript/frameworks/Next.qll

Lines changed: 10 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -286,12 +286,7 @@ module NextJS {
286286
mod.getFile().getStem() = "middleware"
287287
|
288288
this =
289-
mod.getAnExportedValue([any(Http::RequestMethodName m), "middleware"]).getAFunctionValue() and
290-
(
291-
this.getParameter(0).hasUnderlyingType("next/server", "NextRequest")
292-
or
293-
this.getParameter(0).hasUnderlyingType("Request")
294-
)
289+
mod.getAnExportedValue([any(Http::RequestMethodName m), "middleware"]).getAFunctionValue()
295290
)
296291
}
297292

@@ -318,18 +313,17 @@ module NextJS {
318313
) and
319314
kind = "body"
320315
or
321-
(
322-
this = handler.getRequest().getAPropertyRead(["url", "nextUrl"])
323-
or
324-
this =
325-
handler
326-
.getRequest()
327-
.getAPropertyRead("nextUrl")
328-
.getAPropertyRead("searchParams")
329-
.getAMemberCall("get")
330-
) and
316+
this = handler.getRequest().getAPropertyRead(["url", "nextUrl"]) and
331317
kind = "url"
332318
or
319+
this =
320+
handler
321+
.getRequest()
322+
.getAPropertyRead("nextUrl")
323+
.getAPropertyRead("searchParams")
324+
.getAMemberCall("get") and
325+
kind = "parameter"
326+
or
333327
this = handler.getRequest().getAPropertyRead("headers") and kind = "headers"
334328
}
335329

0 commit comments

Comments
 (0)