Skip to content

Commit 1e36561

Browse files
erik-krogherik-krogh
committed
fix all other implicit-this warnings introduced by the acronym patch
1 parent 2e29701 commit 1e36561

File tree

23 files changed

+38
-38
lines changed

23 files changed

+38
-38
lines changed

‎cpp/ql/lib/semmle/code/cpp/ir/implementation/aliased_ssa/Instruction.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ class Instruction extends Construction::TStageInstruction {
211211
final Language::AST getAst() { result = Construction::getInstructionAst(this) }
212212

213213
/** DEPRECATED: Alias for getAst */
214-
deprecated Language::AST getAST() { result = getAst() }
214+
deprecated Language::AST getAST() { result = this.getAst() }
215215

216216
/**
217217
* Gets the location of the source code for this instruction.
@@ -465,7 +465,7 @@ class VariableInstruction extends Instruction {
465465
final Language::Variable getAstVariable() { result = var.(IRUserVariable).getVariable() }
466466

467467
/** DEPRECATED: Alias for getAstVariable */
468-
deprecated Language::Variable getASTVariable() { result = getAstVariable() }
468+
deprecated Language::Variable getASTVariable() { result = this.getAstVariable() }
469469
}
470470

471471
/**

‎cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/Instruction.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ class Instruction extends Construction::TStageInstruction {
211211
final Language::AST getAst() { result = Construction::getInstructionAst(this) }
212212

213213
/** DEPRECATED: Alias for getAst */
214-
deprecated Language::AST getAST() { result = getAst() }
214+
deprecated Language::AST getAST() { result = this.getAst() }
215215

216216
/**
217217
* Gets the location of the source code for this instruction.
@@ -465,7 +465,7 @@ class VariableInstruction extends Instruction {
465465
final Language::Variable getAstVariable() { result = var.(IRUserVariable).getVariable() }
466466

467467
/** DEPRECATED: Alias for getAstVariable */
468-
deprecated Language::Variable getASTVariable() { result = getAstVariable() }
468+
deprecated Language::Variable getASTVariable() { result = this.getAstVariable() }
469469
}
470470

471471
/**

‎cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/internal/TranslatedExpr.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ abstract class TranslatedExpr extends TranslatedElement {
7777
final override Locatable getAst() { result = expr }
7878

7979
/** DEPRECATED: Alias for getAst */
80-
deprecated override Locatable getAST() { result = getAst() }
80+
deprecated override Locatable getAST() { result = this.getAst() }
8181

8282
final override Function getFunction() { result = expr.getEnclosingFunction() }
8383

‎cpp/ql/lib/semmle/code/cpp/ir/implementation/unaliased_ssa/Instruction.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ class Instruction extends Construction::TStageInstruction {
211211
final Language::AST getAst() { result = Construction::getInstructionAst(this) }
212212

213213
/** DEPRECATED: Alias for getAst */
214-
deprecated Language::AST getAST() { result = getAst() }
214+
deprecated Language::AST getAST() { result = this.getAst() }
215215

216216
/**
217217
* Gets the location of the source code for this instruction.
@@ -465,7 +465,7 @@ class VariableInstruction extends Instruction {
465465
final Language::Variable getAstVariable() { result = var.(IRUserVariable).getVariable() }
466466

467467
/** DEPRECATED: Alias for getAstVariable */
468-
deprecated Language::Variable getASTVariable() { result = getAstVariable() }
468+
deprecated Language::Variable getASTVariable() { result = this.getAstVariable() }
469469
}
470470

471471
/**

‎csharp/ql/src/experimental/ir/implementation/raw/Instruction.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ class Instruction extends Construction::TStageInstruction {
211211
final Language::AST getAst() { result = Construction::getInstructionAst(this) }
212212

213213
/** DEPRECATED: Alias for getAst */
214-
deprecated Language::AST getAST() { result = getAst() }
214+
deprecated Language::AST getAST() { result = this.getAst() }
215215

216216
/**
217217
* Gets the location of the source code for this instruction.
@@ -465,7 +465,7 @@ class VariableInstruction extends Instruction {
465465
final Language::Variable getAstVariable() { result = var.(IRUserVariable).getVariable() }
466466

467467
/** DEPRECATED: Alias for getAstVariable */
468-
deprecated Language::Variable getASTVariable() { result = getAstVariable() }
468+
deprecated Language::Variable getASTVariable() { result = this.getAstVariable() }
469469
}
470470

471471
/**

‎csharp/ql/src/experimental/ir/implementation/raw/internal/TranslatedCondition.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ abstract class TranslatedCondition extends ConditionBase {
1818
final override Language::AST getAst() { result = expr }
1919

2020
/** DEPRECATED: Alias for getAst */
21-
deprecated override Language::AST getAST() { result = getAst() }
21+
deprecated override Language::AST getAST() { result = this.getAst() }
2222

2323
final Expr getExpr() { result = expr }
2424

‎csharp/ql/src/experimental/ir/implementation/raw/internal/TranslatedDeclaration.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ abstract class TranslatedLocalDeclaration extends TranslatedElement, TTranslated
3232
final override Language::AST getAst() { result = expr }
3333

3434
/** DEPRECATED: Alias for getAst */
35-
deprecated override Language::AST getAST() { result = getAst() }
35+
deprecated override Language::AST getAST() { result = this.getAst() }
3636
}
3737

3838
/**

‎csharp/ql/src/experimental/ir/implementation/raw/internal/TranslatedElement.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,7 @@ abstract class TranslatedElement extends TTranslatedElement {
368368
abstract Language::AST getAst();
369369

370370
/** DEPRECATED: Alias for getAst */
371-
deprecated Language::AST getAST() { result = getAst() }
371+
deprecated Language::AST getAST() { result = this.getAst() }
372372

373373
/**
374374
* Get the first instruction to be executed in the evaluation of this element.

‎csharp/ql/src/experimental/ir/implementation/raw/internal/TranslatedExpr.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ abstract class TranslatedExpr extends TranslatedExprBase {
6565
final override Language::AST getAst() { result = expr }
6666

6767
/** DEPRECATED: Alias for getAst */
68-
deprecated override Language::AST getAST() { result = getAst() }
68+
deprecated override Language::AST getAST() { result = this.getAst() }
6969

7070
final override Callable getFunction() { result = expr.getEnclosingCallable() }
7171

‎csharp/ql/src/experimental/ir/implementation/raw/internal/TranslatedFunction.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ class TranslatedFunction extends TranslatedElement, TTranslatedFunction {
3131
final override Language::AST getAst() { result = callable }
3232

3333
/** DEPRECATED: Alias for getAst */
34-
deprecated override Language::AST getAST() { result = getAst() }
34+
deprecated override Language::AST getAST() { result = this.getAst() }
3535

3636
/**
3737
* Gets the function being translated.
@@ -288,7 +288,7 @@ class TranslatedParameter extends TranslatedElement, TTranslatedParameter {
288288
final override Language::AST getAst() { result = param }
289289

290290
/** DEPRECATED: Alias for getAst */
291-
deprecated override Language::AST getAST() { result = getAst() }
291+
deprecated override Language::AST getAST() { result = this.getAst() }
292292

293293
final override Callable getFunction() { result = param.getCallable() }
294294

‎csharp/ql/src/experimental/ir/implementation/raw/internal/TranslatedInitialization.qll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ abstract class TranslatedInitialization extends TranslatedElement, TTranslatedIn
5454
final override Language::AST getAst() { result = expr }
5555

5656
/** DEPRECATED: Alias for getAst */
57-
deprecated override Language::AST getAST() { result = getAst() }
57+
deprecated override Language::AST getAST() { result = this.getAst() }
5858

5959
/**
6060
* Gets the expression that is doing the initialization.
@@ -212,7 +212,7 @@ abstract class TranslatedElementInitialization extends TranslatedElement {
212212
final override Language::AST getAst() { result = initList }
213213

214214
/** DEPRECATED: Alias for getAst */
215-
deprecated override Language::AST getAST() { result = getAst() }
215+
deprecated override Language::AST getAST() { result = this.getAst() }
216216

217217
final override Callable getFunction() { result = initList.getEnclosingCallable() }
218218

@@ -319,7 +319,7 @@ abstract class TranslatedConstructorCallFromConstructor extends TranslatedElemen
319319
final override Language::AST getAst() { result = call }
320320

321321
/** DEPRECATED: Alias for getAst */
322-
deprecated override Language::AST getAST() { result = getAst() }
322+
deprecated override Language::AST getAST() { result = this.getAst() }
323323

324324
final override TranslatedElement getChild(int id) {
325325
id = 0 and result = this.getConstructorCall()

‎csharp/ql/src/experimental/ir/implementation/raw/internal/TranslatedStmt.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ abstract class TranslatedStmt extends TranslatedElement, TTranslatedStmt {
2727
final override Language::AST getAst() { result = stmt }
2828

2929
/** DEPRECATED: Alias for getAst */
30-
deprecated override Language::AST getAST() { result = getAst() }
30+
deprecated override Language::AST getAST() { result = this.getAst() }
3131

3232
final override Callable getFunction() { result = stmt.getEnclosingCallable() }
3333
}

‎csharp/ql/src/experimental/ir/implementation/unaliased_ssa/Instruction.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ class Instruction extends Construction::TStageInstruction {
211211
final Language::AST getAst() { result = Construction::getInstructionAst(this) }
212212

213213
/** DEPRECATED: Alias for getAst */
214-
deprecated Language::AST getAST() { result = getAst() }
214+
deprecated Language::AST getAST() { result = this.getAst() }
215215

216216
/**
217217
* Gets the location of the source code for this instruction.
@@ -465,7 +465,7 @@ class VariableInstruction extends Instruction {
465465
final Language::Variable getAstVariable() { result = var.(IRUserVariable).getVariable() }
466466

467467
/** DEPRECATED: Alias for getAstVariable */
468-
deprecated Language::Variable getASTVariable() { result = getAstVariable() }
468+
deprecated Language::Variable getASTVariable() { result = this.getAstVariable() }
469469
}
470470

471471
/**

‎java/ql/lib/semmle/code/java/Expr.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1671,7 +1671,7 @@ class LValue extends VarAccess {
16711671
Expr getRhs() { exists(Assignment e | e.getDest() = this and e.getSource() = result) }
16721672

16731673
/** DEPRECATED: Alias for getRhs */
1674-
deprecated Expr getRHS() { result = getRhs() }
1674+
deprecated Expr getRHS() { result = this.getRhs() }
16751675
}
16761676

16771677
/**

‎java/ql/lib/semmle/code/java/dataflow/SSA.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -929,7 +929,7 @@ class SsaVariable extends TSsaVariable {
929929
}
930930

931931
/** DEPRECATED: Alias for getCfgNode */
932-
deprecated ControlFlowNode getCFGNode() { result = getCfgNode() }
932+
deprecated ControlFlowNode getCFGNode() { result = this.getCfgNode() }
933933

934934
/** Gets a textual representation of this SSA variable. */
935935
string toString() { none() }

‎java/ql/lib/semmle/code/java/dataflow/internal/BaseSSA.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -483,7 +483,7 @@ class BaseSsaVariable extends TBaseSsaVariable {
483483
}
484484

485485
/** DEPRECATED: Alias for getCfgNode */
486-
deprecated ControlFlowNode getCFGNode() { result = getCfgNode() }
486+
deprecated ControlFlowNode getCFGNode() { result = this.getCfgNode() }
487487

488488
string toString() { none() }
489489

‎java/ql/lib/semmle/code/java/frameworks/spring/SpringFlex.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ class SpringRemotingDestinationClass extends Class {
5959

6060
/** DEPRECATED: Alias for getRemotingDestinationXml */
6161
deprecated SpringRemotingDestination getRemotingDestinationXML() {
62-
result = getRemotingDestinationXml()
62+
result = this.getRemotingDestinationXml()
6363
}
6464

6565
/**

‎javascript/ql/lib/semmle/javascript/NPM.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ class NpmPackage extends @folder {
291291
PackageJson getPackageJson() { result = pkg }
292292

293293
/** DEPRECATED: Alias for getPackageJson */
294-
deprecated PackageJSON getPackageJSON() { result = getPackageJson() }
294+
deprecated PackageJSON getPackageJSON() { result = this.getPackageJson() }
295295

296296
/** Gets the name of this package. */
297297
string getPackageName() { result = this.getPackageJson().getPackageName() }

‎javascript/ql/lib/semmle/javascript/PrintAst.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -405,7 +405,7 @@ private module PrintJavaScript {
405405
JsxElement getJsxElement() { result = n }
406406

407407
/** DEPRECATED: Alias for getJsxElement */
408-
deprecated JSXElement getJSXElement() { result = getJsxElement() }
408+
deprecated JSXElement getJSXElement() { result = this.getJsxElement() }
409409

410410
override PrintAstNode getChild(int childIndex) {
411411
result.(ElementNode).getElement() = n.getAttribute(childIndex)
@@ -431,7 +431,7 @@ private module PrintJavaScript {
431431
JsxNode getJsxNode() { result = n }
432432

433433
/** DEPRECATED: Alias for getJsxNode */
434-
deprecated JSXNode getJSXNode() { result = getJsxNode() }
434+
deprecated JSXNode getJSXNode() { result = this.getJsxNode() }
435435

436436
override PrintAstNode getChild(int childIndex) {
437437
result.(ElementNode).getElement() = n.getBodyElement(childIndex)

‎javascript/ql/lib/semmle/javascript/dependencies/Dependencies.qll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ abstract class NpmDependency extends Dependency {
4040
abstract string getNpmPackageName();
4141

4242
/** DEPRECATED: Alias for getNpmPackageName */
43-
deprecated string getNPMPackageName() { result = getNpmPackageName() }
43+
deprecated string getNPMPackageName() { result = this.getNpmPackageName() }
4444

4545
/** Gets the version of the NPM package this module belongs to. */
4646
abstract string getVersion();
@@ -106,7 +106,7 @@ class BundledNpmDependency extends NpmDependency {
106106
override string getNpmPackageName() { result = this.getPackageJson().getPackageName() }
107107

108108
/** DEPRECATED: Alias for getNpmPackageName */
109-
deprecated override string getNPMPackageName() { result = getNpmPackageName() }
109+
deprecated override string getNPMPackageName() { result = this.getNpmPackageName() }
110110

111111
override string getVersion() { result = this.getPackageJson().getVersion() }
112112

@@ -140,7 +140,7 @@ class ExternalNpmDependency extends NpmDependency {
140140
}
141141

142142
/** DEPRECATED: Alias for getNpmPackageName */
143-
deprecated override string getNPMPackageName() { result = getNpmPackageName() }
143+
deprecated override string getNPMPackageName() { result = this.getNpmPackageName() }
144144

145145
private string getVersionNumber() {
146146
exists(string versionRange | versionRange = this.(JsonString).getValue() |

‎javascript/ql/lib/semmle/javascript/dependencies/FrameworkLibraries.qll

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ abstract class FrameworkLibraryWithUrlRegex extends FrameworkLibrary {
139139
abstract string getAUrlRegex();
140140

141141
/** DEPRECATED: Alias for getAUrlRegex */
142-
deprecated string getAURLRegex() { result = getAUrlRegex() }
142+
deprecated string getAURLRegex() { result = this.getAUrlRegex() }
143143
}
144144

145145
/** DEPRECATED: Alias for FrameworkLibraryWithUrlRegex */
@@ -177,7 +177,7 @@ abstract class FrameworkLibraryWithGenericUrl extends FrameworkLibraryWithUrlReg
177177
}
178178

179179
/** DEPRECATED: Alias for getAUrlRegex */
180-
deprecated override string getAURLRegex() { result = getAUrlRegex() }
180+
deprecated override string getAURLRegex() { result = this.getAUrlRegex() }
181181
}
182182

183183
/** DEPRECATED: Alias for FrameworkLibraryWithGenericUrl */
@@ -950,7 +950,7 @@ private class ApplicationInsights extends FrameworkLibraryWithUrlRegex {
950950
override string getAUrlRegex() { result = ".*(?:^|/)ai\\.(" + semverRegex() + ")-build\\d+\\.js" }
951951

952952
/** DEPRECATED: Alias for getAUrlRegex */
953-
deprecated override string getAURLRegex() { result = getAUrlRegex() }
953+
deprecated override string getAURLRegex() { result = this.getAUrlRegex() }
954954
}
955955

956956
/**
@@ -971,7 +971,7 @@ private class TwitterTextClassic extends FrameworkLibraryWithUrlRegex {
971971
override string getAUrlRegex() { result = ".*(?:^|/)twitter_text" + variantRegex() + "\\.js" }
972972

973973
/** DEPRECATED: Alias for getAUrlRegex */
974-
deprecated override string getAURLRegex() { result = getAUrlRegex() }
974+
deprecated override string getAURLRegex() { result = this.getAUrlRegex() }
975975
}
976976

977977
/**

‎javascript/ql/lib/semmle/javascript/frameworks/Markdown.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ module Markdown {
2424
predicate preservesHtml() { any() }
2525

2626
/** DEPRECATED: Alias for preservesHtml */
27-
deprecated predicate preservesHTML() { preservesHtml() }
27+
deprecated predicate preservesHTML() { this.preservesHtml() }
2828
}
2929

3030
private class MarkdownStepAsTaintStep extends TaintTracking::SharedTaintStep {

‎javascript/ql/lib/semmle/javascript/security/dataflow/DOM.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ class DomMethodCallExpr extends MethodCallExpr {
101101
}
102102

103103
/** DEPRECATED: Alias for interpretsArgumentsAsHtml */
104-
deprecated predicate interpretsArgumentsAsHTML(Expr arg) { interpretsArgumentsAsHtml(arg) }
104+
deprecated predicate interpretsArgumentsAsHTML(Expr arg) { this.interpretsArgumentsAsHtml(arg) }
105105
}
106106

107107
/**
@@ -124,7 +124,7 @@ class DomPropWriteNode extends Assignment {
124124
}
125125

126126
/** DEPRECATED: Alias for interpretsValueAsHtml */
127-
deprecated predicate interpretsValueAsHTML() { interpretsValueAsHtml() }
127+
deprecated predicate interpretsValueAsHTML() { this.interpretsValueAsHtml() }
128128

129129
/**
130130
* Holds if the assigned value is interpreted as JavaScript via javascript: protocol.

0 commit comments

Comments
 (0)