Skip to content

Commit 2a5ca8b

Browse files
committed
Python: Remove redundant IncludePostUpdateFlow and PhaseDependentFlow application.
1 parent eacf02a commit 2a5ca8b

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

python/ql/lib/semmle/python/dataflow/new/internal/DataFlowPrivate.qll

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -474,7 +474,7 @@ import StepRelationTransformations
474474
predicate simpleLocalFlowStep(Node nodeFrom, Node nodeTo) {
475475
simpleLocalFlowStepForTypetracking(nodeFrom, nodeTo)
476476
or
477-
summaryFlowSteps(nodeFrom, nodeTo)
477+
summaryLocalStep(nodeFrom, nodeTo)
478478
or
479479
variableCaptureLocalFlowStep(nodeFrom, nodeTo)
480480
}
@@ -495,10 +495,6 @@ private predicate summaryLocalStep(Node nodeFrom, Node nodeTo) {
495495
nodeTo.(FlowSummaryNode).getSummaryNode(), true)
496496
}
497497

498-
predicate summaryFlowSteps(Node nodeFrom, Node nodeTo) {
499-
IncludePostUpdateFlow<PhaseDependentFlow<summaryLocalStep/2>::step/2>::step(nodeFrom, nodeTo)
500-
}
501-
502498
predicate variableCaptureLocalFlowStep(Node nodeFrom, Node nodeTo) {
503499
// Blindly applying use-use flow can result in a node that steps to itself, for
504500
// example in while-loops. To uphold dataflow consistency checks, we don't want

0 commit comments

Comments
 (0)