Skip to content

Commit 5f6e912

Browse files
committed
C++: Generalize FunctionCall to Call in data-flow library
1 parent 29e59e6 commit 5f6e912

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

cpp/ql/src/semmle/code/cpp/dataflow/internal/DataFlowDispatch.qll

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
private import cpp
22

3-
Function viableImpl(FunctionCall call) { result = viableCallable(call) }
3+
Function viableImpl(Call call) { result = viableCallable(call) }
44

55
/**
66
* Gets a function that might be called by `call`.
@@ -58,23 +58,23 @@ private predicate functionSignature(Function f, string qualifiedName, int nparam
5858
* Holds if the call context `ctx` reduces the set of viable dispatch
5959
* targets of `ma` in `c`.
6060
*/
61-
predicate reducedViableImplInCallContext(FunctionCall call, Function f, Call ctx) { none() }
61+
predicate reducedViableImplInCallContext(Call call, Function f, Call ctx) { none() }
6262

6363
/**
6464
* Gets a viable dispatch target of `ma` in the context `ctx`. This is
6565
* restricted to those `ma`s for which the context makes a difference.
6666
*/
67-
Function prunedViableImplInCallContext(FunctionCall call, Call ctx) { none() }
67+
Function prunedViableImplInCallContext(Call call, Call ctx) { none() }
6868

6969
/**
7070
* Holds if flow returning from `m` to `ma` might return further and if
7171
* this path restricts the set of call sites that can be returned to.
7272
*/
73-
predicate reducedViableImplInReturn(Function f, FunctionCall call) { none() }
73+
predicate reducedViableImplInReturn(Function f, Call call) { none() }
7474

7575
/**
7676
* Gets a viable dispatch target of `ma` in the context `ctx`. This is
7777
* restricted to those `ma`s and results for which the return flow from the
7878
* result to `ma` restricts the possible context `ctx`.
7979
*/
80-
Function prunedViableImplInCallContextReverse(FunctionCall call, Call ctx) { none() }
80+
Function prunedViableImplInCallContextReverse(Call call, Call ctx) { none() }

cpp/ql/src/semmle/code/cpp/dataflow/internal/DataFlowPrivate.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ class ReturnNode extends ExprNode {
7474

7575
/** A data flow node that represents a call. */
7676
class OutNode extends ExprNode {
77-
OutNode() { this.getExpr() instanceof FunctionCall }
77+
OutNode() { this.getExpr() instanceof Call }
7878

7979
/** Gets the underlying call. */
8080
DataFlowCall getCall() { result = this.getExpr() }

0 commit comments

Comments
 (0)