Skip to content

Commit 66130d2

Browse files
committed
convert abstract predicate isAdditionalFlowStep to non-abstract
1 parent 1927530 commit 66130d2

File tree

1 file changed

+1
-65
lines changed

1 file changed

+1
-65
lines changed

go/ql/src/experimental/frameworks/DecompressionBombsCustomizations.qll

Lines changed: 1 addition & 65 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ module DecompressionBombs {
2121
/**
2222
* Holds if there is a additional taint step between pred and succ.
2323
*/
24-
abstract predicate isAdditionalFlowStep(DataFlow::Node fromNode, DataFlow::Node toNode);
24+
predicate isAdditionalFlowStep(DataFlow::Node fromNode, DataFlow::Node toNode) { none() }
2525

2626
/**
2727
* Holds if there is a additional taint step between pred and succ.
@@ -56,10 +56,6 @@ module DecompressionBombs {
5656
toState = "ZstdNewReader"
5757
)
5858
}
59-
60-
override predicate isAdditionalFlowStep(DataFlow::Node fromNode, DataFlow::Node toNode) {
61-
none()
62-
}
6359
}
6460
}
6561

@@ -93,10 +89,6 @@ module DecompressionBombs {
9389
toState = "ZstdNewReader"
9490
)
9591
}
96-
97-
override predicate isAdditionalFlowStep(DataFlow::Node fromNode, DataFlow::Node toNode) {
98-
none()
99-
}
10092
}
10193
}
10294

@@ -119,10 +111,6 @@ module DecompressionBombs {
119111
toState = "ZipOpenReader"
120112
)
121113
}
122-
123-
override predicate isAdditionalFlowStep(DataFlow::Node fromNode, DataFlow::Node toNode) {
124-
none()
125-
}
126114
}
127115
}
128116

@@ -185,10 +173,6 @@ module DecompressionBombs {
185173
toState = "XzNewReader"
186174
)
187175
}
188-
189-
override predicate isAdditionalFlowStep(DataFlow::Node fromNode, DataFlow::Node toNode) {
190-
none()
191-
}
192176
}
193177
}
194178

@@ -212,10 +196,6 @@ module DecompressionBombs {
212196
toState = "GzipNewReader"
213197
)
214198
}
215-
216-
override predicate isAdditionalFlowStep(DataFlow::Node fromNode, DataFlow::Node toNode) {
217-
none()
218-
}
219199
}
220200
}
221201

@@ -245,10 +225,6 @@ module DecompressionBombs {
245225
toState = "GzipNewReader"
246226
)
247227
}
248-
249-
override predicate isAdditionalFlowStep(DataFlow::Node fromNode, DataFlow::Node toNode) {
250-
none()
251-
}
252228
}
253229
}
254230

@@ -272,10 +248,6 @@ module DecompressionBombs {
272248
toState = "Bzip2NewReader"
273249
)
274250
}
275-
276-
override predicate isAdditionalFlowStep(DataFlow::Node fromNode, DataFlow::Node toNode) {
277-
none()
278-
}
279251
}
280252
}
281253

@@ -299,10 +271,6 @@ module DecompressionBombs {
299271
toState = "Bzip2NewReader"
300272
)
301273
}
302-
303-
override predicate isAdditionalFlowStep(DataFlow::Node fromNode, DataFlow::Node toNode) {
304-
none()
305-
}
306274
}
307275
}
308276

@@ -326,10 +294,6 @@ module DecompressionBombs {
326294
toState = "FlateNewReader"
327295
)
328296
}
329-
330-
override predicate isAdditionalFlowStep(DataFlow::Node fromNode, DataFlow::Node toNode) {
331-
none()
332-
}
333297
}
334298
}
335299

@@ -365,10 +329,6 @@ module DecompressionBombs {
365329
toState = "FlateNewReader"
366330
)
367331
}
368-
369-
override predicate isAdditionalFlowStep(DataFlow::Node fromNode, DataFlow::Node toNode) {
370-
none()
371-
}
372332
}
373333
}
374334

@@ -404,10 +364,6 @@ module DecompressionBombs {
404364
toState = "FlateNewReader"
405365
)
406366
}
407-
408-
override predicate isAdditionalFlowStep(DataFlow::Node fromNode, DataFlow::Node toNode) {
409-
none()
410-
}
411367
}
412368
}
413369

@@ -431,10 +387,6 @@ module DecompressionBombs {
431387
toState = "ZlibNewReader"
432388
)
433389
}
434-
435-
override predicate isAdditionalFlowStep(DataFlow::Node fromNode, DataFlow::Node toNode) {
436-
none()
437-
}
438390
}
439391
}
440392

@@ -458,10 +410,6 @@ module DecompressionBombs {
458410
toState = "ZlibNewReader"
459411
)
460412
}
461-
462-
override predicate isAdditionalFlowStep(DataFlow::Node fromNode, DataFlow::Node toNode) {
463-
none()
464-
}
465413
}
466414
}
467415

@@ -485,10 +433,6 @@ module DecompressionBombs {
485433
toState = "SnappyNewReader"
486434
)
487435
}
488-
489-
override predicate isAdditionalFlowStep(DataFlow::Node fromNode, DataFlow::Node toNode) {
490-
none()
491-
}
492436
}
493437
}
494438

@@ -512,10 +456,6 @@ module DecompressionBombs {
512456
toState = "SnappyNewReader"
513457
)
514458
}
515-
516-
override predicate isAdditionalFlowStep(DataFlow::Node fromNode, DataFlow::Node toNode) {
517-
none()
518-
}
519459
}
520460
}
521461

@@ -551,10 +491,6 @@ module DecompressionBombs {
551491
toState = "S2NewReader"
552492
)
553493
}
554-
555-
override predicate isAdditionalFlowStep(DataFlow::Node fromNode, DataFlow::Node toNode) {
556-
none()
557-
}
558494
}
559495
}
560496

0 commit comments

Comments
 (0)