C++: Strip away specifiers and typedefs when finding iterator parameters for a string taint function.

MathiasVP · MathiasVP · commit 813f08ef5745 · 2024-07-12T09:54:04.000+01:00
diff --git a/cpp/ql/lib/semmle/code/cpp/models/implementations/StdString.qll b/cpp/ql/lib/semmle/code/cpp/models/implementations/StdString.qll
@@ -66,7 +66,7 @@ abstract private class StdStringTaintFunction extends TaintFunction {
    * Gets the index of a parameter to this function that is an iterator.
    */
   final int getAnIteratorParameterIndex() {
-    this.getParameter(result).getType() instanceof Iterator
+    this.getParameter(result).getUnspecifiedType() instanceof Iterator
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ abstract private class StdStringTaintFunction extends TaintFunction {`
`66`	`66`	`* Gets the index of a parameter to this function that is an iterator.`
`67`	`67`	`*/`
`68`	`68`	`final int getAnIteratorParameterIndex() {`
`69`		`- this.getParameter(result).getType() instanceof Iterator`
	`69`	`+ this.getParameter(result).getUnspecifiedType() instanceof Iterator`
`70`	`70`	`}`
`71`	`71`	`}`
`72`	`72`