Skip to content

Commit 90a4552

Browse files
author
Max Schaefer
committed
Fix omittable exists.
1 parent fee4407 commit 90a4552

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

java/ql/automodel/src/AutomodelApplicationModeExtractNegativeExamples.ql

+2-2
Original file line numberDiff line numberDiff line change
@@ -57,10 +57,10 @@ predicate candidate(
5757
isVarargsArray, _, extensibleType) and
5858
// It's valid for a node to be both a potential source/sanitizer and a sink. We don't want to include such nodes
5959
// as negative examples in the prompt, because they're ambiguous and might confuse the model, so we explicitly them here.
60-
not exists(EndpointCharacteristic characteristic2, float confidence2, EndpointType type2 |
60+
not exists(EndpointCharacteristic characteristic2, float confidence2 |
6161
characteristic2.appliesToEndpoint(endpoint) and
6262
confidence2 >= SharedCharacteristics::maximalConfidence() and
63-
characteristic2.hasImplications(type2, true, confidence2)
63+
characteristic2.hasImplications(endpoint.getAPotentialType(), true, confidence2)
6464
)
6565
}
6666

java/ql/automodel/src/AutomodelFrameworkModeExtractNegativeExamples.ql

+2-2
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,10 @@ where
3131
_, extensibleType) and
3232
// It's valid for a node to be both a potential source/sanitizer and a sink. We don't want to include such nodes
3333
// as negative examples in the prompt, because they're ambiguous and might confuse the model, so we explicitly them here.
34-
not exists(EndpointCharacteristic characteristic2, float confidence2, EndpointType type2 |
34+
not exists(EndpointCharacteristic characteristic2, float confidence2 |
3535
characteristic2.appliesToEndpoint(endpoint) and
3636
confidence2 >= SharedCharacteristics::maximalConfidence() and
37-
characteristic2.hasImplications(type2, true, confidence2)
37+
characteristic2.hasImplications(endpoint.getAPotentialType(), true, confidence2)
3838
) and
3939
message = characteristic
4040
select endpoint,

0 commit comments

Comments
 (0)