CPP: deprecate some unused but publicly visible predicates

Author: erik-krogh

cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowUtil.qll

@@ -715,7 +715,7 @@ ExprNode exprNode(Expr e) { result.getExpr() = e }
  * argument is passed by reference, use
  * `definitionByReferenceNodeFromArgument` instead.
  */
-ExprNode convertedExprNode(Expr e) { result.getConvertedExpr() = e }
+deprecated ExprNode convertedExprNode(Expr e) { result.getConvertedExpr() = e }
 
 /**
  * Gets the `Node` corresponding to the value of `p` at function entry.
@@ -731,15 +731,15 @@ DefinitionByReferenceNode definitionByReferenceNodeFromArgument(Expr argument) {
 }
 
 /** Gets the `VariableNode` corresponding to the variable `v`. */
-VariableNode variableNode(Variable v) { result.getVariable() = v }
+deprecated VariableNode variableNode(Variable v) { result.getVariable() = v }
 
 /**
  * DEPRECATED: See UninitializedNode.
  *
  * Gets the `Node` corresponding to the value of an uninitialized local
  * variable `v`.
  */
-Node uninitializedNode(LocalVariable v) { none() }
+deprecated Node uninitializedNode(LocalVariable v) { none() }
 
 /**
  * Holds if data flows from `nodeFrom` to `nodeTo` in exactly one local
@@ -1008,7 +1008,7 @@ predicate localFlow(Node source, Node sink) { localFlowStep*(source, sink) }
  * local (intra-procedural) steps.
  */
 pragma[inline]
-predicate localInstructionFlow(Instruction e1, Instruction e2) {
+deprecated predicate localInstructionFlow(Instruction e1, Instruction e2) {
   localFlow(instructionNode(e1), instructionNode(e2))
 }
 
@@ -1017,7 +1017,7 @@ predicate localInstructionFlow(Instruction e1, Instruction e2) {
  * local (intra-procedural) steps.
  */
 pragma[inline]
-predicate localExprFlow(Expr e1, Expr e2) { localFlow(exprNode(e1), exprNode(e2)) }
+deprecated predicate localExprFlow(Expr e1, Expr e2) { localFlow(exprNode(e1), exprNode(e2)) }
 
 private newtype TContent =
   TFieldContent(Field f) {

cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/SsaInternals.qll

@@ -267,7 +267,9 @@ Instruction getSourceAddressFromNode(Node node) {
 }
 
 /** Gets the source value of `instr` if it's an instruction that behaves like a `LoadInstruction`. */
-Instruction getSourceValue(Instruction instr) { result = getSourceValueOperand(instr).getDef() }
+deprecated Instruction getSourceValue(Instruction instr) {
+  result = getSourceValueOperand(instr).getDef()
+}
 
 /**
  * Gets the operand that represents the source value of `instr` if it's an instruction