C#: Remove requirement that a controller is not allowed to be abstract.

michaelnebel · michaelnebel · commit a6e4ec40ff68 · 2024-08-21T12:14:50.000+02:00
diff --git a/csharp/ql/lib/semmle/code/csharp/frameworks/microsoft/AspNetCore.qll b/csharp/ql/lib/semmle/code/csharp/frameworks/microsoft/AspNetCore.qll
@@ -205,7 +205,6 @@ class MicrosoftAspNetCoreMvcController extends Class {
       )
     ) and
     this.isPublic() and
-    (not this.isAbstract() or this instanceof MicrosoftAspNetCoreMvcControllerBaseClass) and
     not this instanceof Generic and
     (
       this.getABaseType*() instanceof MicrosoftAspNetCoreMvcControllerBaseClass

Original file line number	Diff line number	Diff line change
`@@ -205,7 +205,6 @@ class MicrosoftAspNetCoreMvcController extends Class {`
`205`	`205`	`)`
`206`	`206`	`) and`
`207`	`207`	`this.isPublic() and`
`208`		`- (not this.isAbstract() or this instanceof MicrosoftAspNetCoreMvcControllerBaseClass) and`
`209`	`208`	`not this instanceof Generic and`
`210`	`209`	`(`
`211`	`210`	`this.getABaseType*() instanceof MicrosoftAspNetCoreMvcControllerBaseClass`