Skip to content

Commit aea573b

Browse files
committed
JS: Update test output and add related TODO in 'markdown-table' model
1 parent 9acae1b commit aea573b

File tree

3 files changed

+2
-2
lines changed

3 files changed

+2
-2
lines changed

javascript/ql/lib/semmle/javascript/frameworks/Markdown.qll

+1
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ module Markdown {
5252
private class MarkdownTableStep extends MarkdownStep {
5353
override predicate step(DataFlow::Node pred, DataFlow::Node succ) {
5454
exists(DataFlow::CallNode call | call = DataFlow::moduleImport("markdown-table").getACall() |
55+
// TODO: needs a flow summary to ensure ArrayElement content is unfolded
5556
succ = call and
5657
pred = call.getArgument(0)
5758
)

javascript/ql/test/query-tests/Security/CWE-079/ReflectedXss/ReflectedXss.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ app.get('/user/:id', function(req, res) {
3131
['Name', 'Content'],
3232
['body', req.body]
3333
]);
34-
res.send(mytable); // NOT OK
34+
res.send(mytable); // NOT OK - FIXME: only works in OLD dataflow, add implicit reads before library-contributed taint steps
3535
});
3636

3737
var showdown = require('showdown');

javascript/ql/test/query-tests/Security/CWE-079/ReflectedXss/ReflectedXssWithCustomSanitizer.expected

-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
| ReflectedXss.js:22:12:22:19 | req.body | Cross-site scripting vulnerability due to $@. | ReflectedXss.js:22:12:22:19 | req.body | user-provided value |
44
| ReflectedXss.js:23:12:23:27 | marked(req.body) | Cross-site scripting vulnerability due to $@. | ReflectedXss.js:23:19:23:26 | req.body | user-provided value |
55
| ReflectedXss.js:29:12:29:19 | req.body | Cross-site scripting vulnerability due to $@. | ReflectedXss.js:29:12:29:19 | req.body | user-provided value |
6-
| ReflectedXss.js:34:12:34:18 | mytable | Cross-site scripting vulnerability due to $@. | ReflectedXss.js:32:14:32:21 | req.body | user-provided value |
76
| ReflectedXss.js:41:12:41:19 | req.body | Cross-site scripting vulnerability due to $@. | ReflectedXss.js:41:12:41:19 | req.body | user-provided value |
87
| ReflectedXss.js:42:12:42:39 | convert ... q.body) | Cross-site scripting vulnerability due to $@. | ReflectedXss.js:42:31:42:38 | req.body | user-provided value |
98
| ReflectedXss.js:56:12:56:19 | req.body | Cross-site scripting vulnerability due to $@. | ReflectedXss.js:56:12:56:19 | req.body | user-provided value |

0 commit comments

Comments
 (0)