Skip to content

Commit cb5dbb9

Browse files
committed
JS: Update test to reflect implicit read flow has been fixed
Shows the effect of #17262
1 parent a2d53c2 commit cb5dbb9

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

javascript/ql/test/library-tests/TaintTracking/BasicTaintTracking.expected

-2
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ legacyDataFlowDifference
3535
| spread.js:4:15:4:22 | source() | spread.js:18:8:18:8 | y | only flow with NEW data flow library |
3636
| spread.js:4:15:4:22 | source() | spread.js:24:8:24:8 | y | only flow with NEW data flow library |
3737
| use-use-after-implicit-read.js:7:17:7:24 | source() | use-use-after-implicit-read.js:15:10:15:10 | x | only flow with NEW data flow library |
38-
| use-use-after-implicit-read.js:7:17:7:24 | source() | use-use-after-implicit-read.js:16:10:16:10 | y | only flow with NEW data flow library |
3938
consistencyIssue
4039
| library-tests/TaintTracking/nested-props.js:20 | expected an alert, but found none | NOT OK - but not found | Consistency |
4140
| library-tests/TaintTracking/stringification-read-steps.js:17 | expected an alert, but found none | NOT OK | Consistency |
@@ -297,7 +296,6 @@ flow
297296
| tst.js:2:13:2:20 | source() | tst.js:54:14:54:19 | unsafe |
298297
| use-use-after-implicit-read.js:7:17:7:24 | source() | use-use-after-implicit-read.js:8:10:8:17 | captured |
299298
| use-use-after-implicit-read.js:7:17:7:24 | source() | use-use-after-implicit-read.js:15:10:15:10 | x |
300-
| use-use-after-implicit-read.js:7:17:7:24 | source() | use-use-after-implicit-read.js:16:10:16:10 | y |
301299
| xml.js:5:18:5:25 | source() | xml.js:8:14:8:17 | text |
302300
| xml.js:12:17:12:24 | source() | xml.js:13:14:13:19 | result |
303301
| xml.js:23:18:23:25 | source() | xml.js:20:14:20:17 | attr |

javascript/ql/test/library-tests/TaintTracking/use-use-after-implicit-read.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@ function f(x) {
1313

1414
function g(x, y) {
1515
sink(x); // NOT OK
16-
sink(y); // OK [INCONSISTENCY] - implicit read confuses array index
16+
sink(y); // OK
1717
}

0 commit comments

Comments
 (0)