Skip to content

Commit cff950f

Browse files
RasmusWLRasmusWL
committed
Python: Fix select of py/insecure-cookie 
1 parent fc8633c commit cff950f

File tree

2 files changed

+31
-31
lines changed

2 files changed

+31
-31
lines changed

‎python/ql/src/experimental/Security/CWE-614/InsecureCookie.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,4 +27,4 @@ where
2727
or
2828
not cookie.isSameSite() and
2929
alert = "samesite"
30-
select cookie, "Cookie is added without the ", alert, " flag properly set."
30+
select cookie, "Cookie is added without the '" + alert + "' flag properly set."

‎python/ql/test/experimental/query-tests/Security/CWE-614/InsecureCookie.expected

Lines changed: 30 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,30 @@
1-
| django_bad.py:6:5:7:52 | ControlFlowNode for Attribute() | Cookie is added without the | httponly | flag properly set. |
2-
| django_bad.py:6:5:7:52 | ControlFlowNode for Attribute() | Cookie is added without the | samesite | flag properly set. |
3-
| django_bad.py:6:5:7:52 | ControlFlowNode for Attribute() | Cookie is added without the | secure | flag properly set. |
4-
| django_bad.py:13:5:13:26 | ControlFlowNode for Subscript | Cookie is added without the | httponly | flag properly set. |
5-
| django_bad.py:13:5:13:26 | ControlFlowNode for Subscript | Cookie is added without the | samesite | flag properly set. |
6-
| django_bad.py:13:5:13:26 | ControlFlowNode for Subscript | Cookie is added without the | secure | flag properly set. |
7-
| django_bad.py:19:5:21:66 | ControlFlowNode for Attribute() | Cookie is added without the | httponly | flag properly set. |
8-
| django_bad.py:19:5:21:66 | ControlFlowNode for Attribute() | Cookie is added without the | samesite | flag properly set. |
9-
| django_bad.py:19:5:21:66 | ControlFlowNode for Attribute() | Cookie is added without the | secure | flag properly set. |
10-
| django_bad.py:27:5:27:26 | ControlFlowNode for Subscript | Cookie is added without the | httponly | flag properly set. |
11-
| django_bad.py:27:5:27:26 | ControlFlowNode for Subscript | Cookie is added without the | samesite | flag properly set. |
12-
| django_bad.py:27:5:27:26 | ControlFlowNode for Subscript | Cookie is added without the | secure | flag properly set. |
13-
| django_good.py:19:5:19:44 | ControlFlowNode for Attribute() | Cookie is added without the | httponly | flag properly set. |
14-
| django_good.py:19:5:19:44 | ControlFlowNode for Attribute() | Cookie is added without the | samesite | flag properly set. |
15-
| django_good.py:19:5:19:44 | ControlFlowNode for Attribute() | Cookie is added without the | secure | flag properly set. |
16-
| flask_bad.py:9:5:10:52 | ControlFlowNode for Attribute() | Cookie is added without the | httponly | flag properly set. |
17-
| flask_bad.py:9:5:10:52 | ControlFlowNode for Attribute() | Cookie is added without the | samesite | flag properly set. |
18-
| flask_bad.py:9:5:10:52 | ControlFlowNode for Attribute() | Cookie is added without the | secure | flag properly set. |
19-
| flask_bad.py:17:5:17:30 | ControlFlowNode for Subscript | Cookie is added without the | httponly | flag properly set. |
20-
| flask_bad.py:17:5:17:30 | ControlFlowNode for Subscript | Cookie is added without the | samesite | flag properly set. |
21-
| flask_bad.py:17:5:17:30 | ControlFlowNode for Subscript | Cookie is added without the | secure | flag properly set. |
22-
| flask_bad.py:24:5:25:52 | ControlFlowNode for Attribute() | Cookie is added without the | httponly | flag properly set. |
23-
| flask_bad.py:24:5:25:52 | ControlFlowNode for Attribute() | Cookie is added without the | samesite | flag properly set. |
24-
| flask_bad.py:24:5:25:52 | ControlFlowNode for Attribute() | Cookie is added without the | secure | flag properly set. |
25-
| flask_bad.py:32:5:32:30 | ControlFlowNode for Subscript | Cookie is added without the | httponly | flag properly set. |
26-
| flask_bad.py:32:5:32:30 | ControlFlowNode for Subscript | Cookie is added without the | samesite | flag properly set. |
27-
| flask_bad.py:32:5:32:30 | ControlFlowNode for Subscript | Cookie is added without the | secure | flag properly set. |
28-
| flask_good.py:23:5:23:57 | ControlFlowNode for Attribute() | Cookie is added without the | httponly | flag properly set. |
29-
| flask_good.py:23:5:23:57 | ControlFlowNode for Attribute() | Cookie is added without the | samesite | flag properly set. |
30-
| flask_good.py:23:5:23:57 | ControlFlowNode for Attribute() | Cookie is added without the | secure | flag properly set. |
1+
| django_bad.py:6:5:7:52 | ControlFlowNode for Attribute() | Cookie is added without the 'httponly' flag properly set. |
2+
| django_bad.py:6:5:7:52 | ControlFlowNode for Attribute() | Cookie is added without the 'samesite' flag properly set. |
3+
| django_bad.py:6:5:7:52 | ControlFlowNode for Attribute() | Cookie is added without the 'secure' flag properly set. |
4+
| django_bad.py:13:5:13:26 | ControlFlowNode for Subscript | Cookie is added without the 'httponly' flag properly set. |
5+
| django_bad.py:13:5:13:26 | ControlFlowNode for Subscript | Cookie is added without the 'samesite' flag properly set. |
6+
| django_bad.py:13:5:13:26 | ControlFlowNode for Subscript | Cookie is added without the 'secure' flag properly set. |
7+
| django_bad.py:19:5:21:66 | ControlFlowNode for Attribute() | Cookie is added without the 'httponly' flag properly set. |
8+
| django_bad.py:19:5:21:66 | ControlFlowNode for Attribute() | Cookie is added without the 'samesite' flag properly set. |
9+
| django_bad.py:19:5:21:66 | ControlFlowNode for Attribute() | Cookie is added without the 'secure' flag properly set. |
10+
| django_bad.py:27:5:27:26 | ControlFlowNode for Subscript | Cookie is added without the 'httponly' flag properly set. |
11+
| django_bad.py:27:5:27:26 | ControlFlowNode for Subscript | Cookie is added without the 'samesite' flag properly set. |
12+
| django_bad.py:27:5:27:26 | ControlFlowNode for Subscript | Cookie is added without the 'secure' flag properly set. |
13+
| django_good.py:19:5:19:44 | ControlFlowNode for Attribute() | Cookie is added without the 'httponly' flag properly set. |
14+
| django_good.py:19:5:19:44 | ControlFlowNode for Attribute() | Cookie is added without the 'samesite' flag properly set. |
15+
| django_good.py:19:5:19:44 | ControlFlowNode for Attribute() | Cookie is added without the 'secure' flag properly set. |
16+
| flask_bad.py:9:5:10:52 | ControlFlowNode for Attribute() | Cookie is added without the 'httponly' flag properly set. |
17+
| flask_bad.py:9:5:10:52 | ControlFlowNode for Attribute() | Cookie is added without the 'samesite' flag properly set. |
18+
| flask_bad.py:9:5:10:52 | ControlFlowNode for Attribute() | Cookie is added without the 'secure' flag properly set. |
19+
| flask_bad.py:17:5:17:30 | ControlFlowNode for Subscript | Cookie is added without the 'httponly' flag properly set. |
20+
| flask_bad.py:17:5:17:30 | ControlFlowNode for Subscript | Cookie is added without the 'samesite' flag properly set. |
21+
| flask_bad.py:17:5:17:30 | ControlFlowNode for Subscript | Cookie is added without the 'secure' flag properly set. |
22+
| flask_bad.py:24:5:25:52 | ControlFlowNode for Attribute() | Cookie is added without the 'httponly' flag properly set. |
23+
| flask_bad.py:24:5:25:52 | ControlFlowNode for Attribute() | Cookie is added without the 'samesite' flag properly set. |
24+
| flask_bad.py:24:5:25:52 | ControlFlowNode for Attribute() | Cookie is added without the 'secure' flag properly set. |
25+
| flask_bad.py:32:5:32:30 | ControlFlowNode for Subscript | Cookie is added without the 'httponly' flag properly set. |
26+
| flask_bad.py:32:5:32:30 | ControlFlowNode for Subscript | Cookie is added without the 'samesite' flag properly set. |
27+
| flask_bad.py:32:5:32:30 | ControlFlowNode for Subscript | Cookie is added without the 'secure' flag properly set. |
28+
| flask_good.py:23:5:23:57 | ControlFlowNode for Attribute() | Cookie is added without the 'httponly' flag properly set. |
29+
| flask_good.py:23:5:23:57 | ControlFlowNode for Attribute() | Cookie is added without the 'samesite' flag properly set. |
30+
| flask_good.py:23:5:23:57 | ControlFlowNode for Attribute() | Cookie is added without the 'secure' flag properly set. |

0 commit comments

Comments
 (0)