Skip to content

Commit ea20e9b

Browse files
author
Alvaro Muñoz
committed
fix: Add versioned python binaries to poisonable steps
1 parent 230b2ff commit ea20e9b

File tree

4 files changed

+11
-6
lines changed

4 files changed

+11
-6
lines changed

ql/lib/ext/config/poisonable_steps.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@ extensions:
4747
- ["poetry"]
4848
- ["pylint"]
4949
- ["pytest"]
50-
- ["python\\s+-m\\s+pip\\s+install\\s+-r"]
51-
- ["python\\s+-m\\s+pip\\s+install\\s+--requirement"]
50+
- ["python[\\d\\.]*\\s+-m\\s+pip\\s+install\\s+-r"]
51+
- ["python[\\d\\.]*\\s+-m\\s+pip\\s+install\\s+--requirement"]
5252
- ["rake"]
5353
- ["rails\\s+db:create"]
5454
- ["rails\\s+assets:precompile"]
@@ -69,7 +69,7 @@ extensions:
6969
- ["(\\.\\s+[^\\s]+)\\b", 1] # eg: . venv/bin/activate
7070
- ["(source|sh|bash|zsh|fish)\\s+([^\\s]+)\\b", 2]
7171
- ["(node)\\s+([^\\s]+)(\\.js|\\.ts)\\b", 2]
72-
- ["(python)\\s+([^\\s]+)\\.py\\b", 2]
72+
- ["(python[\\d\\.]*)\\s+([^\\s]+)\\.py\\b", 2]
7373
- ["(ruby)\\s+([^\\s]+)\\.rb\\b", 2]
7474
- ["(go)\\s+(generate|run)\\s+([^\\s]+)\\.go\\b", 3]
7575
- ["(dotnet)\\s+([^\\s]+)\\.csproj\\b", 2]

ql/test/query-tests/Security/CWE-829/.github/workflows/test4.yml

+1
Original file line numberDiff line numberDiff line change
@@ -44,3 +44,4 @@ jobs:
4444
uses: actions/upload-pages-artifact@v1
4545
with:
4646
path: './workspaces/www/build'
47+
- run: python2.7 foo.py

ql/test/query-tests/Security/CWE-829/.github/workflows/test7.yml

+1
Original file line numberDiff line numberDiff line change
@@ -56,3 +56,4 @@ jobs:
5656
echo "$processed" >> $GITHUB_OUTPUT
5757
echo "BENCHEOF" >> $GITHUB_OUTPUT
5858
shell: bash
59+
- run: python2.7 foo.py

ql/test/query-tests/Security/CWE-829/UntrustedCheckoutCritical.expected

+6-3
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,8 @@ edges
189189
| .github/workflows/test4.yml:38:7:40:4 | Run Step | .github/workflows/test4.yml:40:7:41:4 | Run Step |
190190
| .github/workflows/test4.yml:40:7:41:4 | Run Step | .github/workflows/test4.yml:41:7:42:4 | Run Step |
191191
| .github/workflows/test4.yml:41:7:42:4 | Run Step | .github/workflows/test4.yml:42:7:43:4 | Run Step |
192-
| .github/workflows/test4.yml:42:7:43:4 | Run Step | .github/workflows/test4.yml:43:7:46:39 | Uses Step |
192+
| .github/workflows/test4.yml:42:7:43:4 | Run Step | .github/workflows/test4.yml:43:7:47:4 | Uses Step |
193+
| .github/workflows/test4.yml:43:7:47:4 | Uses Step | .github/workflows/test4.yml:47:7:47:28 | Run Step |
193194
| .github/workflows/test5.yml:13:9:28:6 | Uses Step: issue | .github/workflows/test5.yml:28:9:32:6 | Uses Step |
194195
| .github/workflows/test5.yml:28:9:32:6 | Uses Step | .github/workflows/test5.yml:32:9:34:2 | Run Step |
195196
| .github/workflows/test5.yml:39:9:54:6 | Uses Step: issue | .github/workflows/test5.yml:54:9:58:6 | Uses Step |
@@ -202,7 +203,8 @@ edges
202203
| .github/workflows/test7.yml:27:9:33:6 | Uses Step | .github/workflows/test7.yml:33:9:36:6 | Run Step |
203204
| .github/workflows/test7.yml:33:9:36:6 | Run Step | .github/workflows/test7.yml:36:9:39:6 | Run Step |
204205
| .github/workflows/test7.yml:36:9:39:6 | Run Step | .github/workflows/test7.yml:39:9:49:6 | Run Step: bench-command |
205-
| .github/workflows/test7.yml:39:9:49:6 | Run Step: bench-command | .github/workflows/test7.yml:49:9:58:20 | Run Step: benchmark-pr |
206+
| .github/workflows/test7.yml:39:9:49:6 | Run Step: bench-command | .github/workflows/test7.yml:49:9:59:6 | Run Step: benchmark-pr |
207+
| .github/workflows/test7.yml:49:9:59:6 | Run Step: benchmark-pr | .github/workflows/test7.yml:59:9:59:30 | Run Step |
206208
| .github/workflows/test8.yml:20:9:26:6 | Uses Step | .github/workflows/test8.yml:26:9:29:2 | Run Step |
207209
| .github/workflows/test9.yml:11:9:16:6 | Uses Step | .github/workflows/test9.yml:16:9:17:48 | Run Step |
208210
| .github/workflows/test10.yml:20:9:25:6 | Uses Step | .github/workflows/test10.yml:25:9:30:2 | Run Step |
@@ -342,7 +344,8 @@ edges
342344
| .github/workflows/reusable_local.yml:26:9:29:7 | Run Step | .github/workflows/reusable_local.yml:23:9:26:6 | Uses Step | .github/workflows/reusable_local.yml:26:9:29:7 | Run Step | Potential execution of untrusted code on a privileged workflow ($@) | .github/workflows/reusable_caller3.yaml:4:3:4:21 | pull_request_target | pull_request_target |
343345
| .github/workflows/test7.yml:33:9:36:6 | Run Step | .github/workflows/test7.yml:19:9:24:6 | Uses Step | .github/workflows/test7.yml:33:9:36:6 | Run Step | Potential execution of untrusted code on a privileged workflow ($@) | .github/workflows/test7.yml:4:3:4:15 | issue_comment | issue_comment |
344346
| .github/workflows/test7.yml:36:9:39:6 | Run Step | .github/workflows/test7.yml:19:9:24:6 | Uses Step | .github/workflows/test7.yml:36:9:39:6 | Run Step | Potential execution of untrusted code on a privileged workflow ($@) | .github/workflows/test7.yml:4:3:4:15 | issue_comment | issue_comment |
345-
| .github/workflows/test7.yml:49:9:58:20 | Run Step: benchmark-pr | .github/workflows/test7.yml:19:9:24:6 | Uses Step | .github/workflows/test7.yml:49:9:58:20 | Run Step: benchmark-pr | Potential execution of untrusted code on a privileged workflow ($@) | .github/workflows/test7.yml:4:3:4:15 | issue_comment | issue_comment |
347+
| .github/workflows/test7.yml:49:9:59:6 | Run Step: benchmark-pr | .github/workflows/test7.yml:19:9:24:6 | Uses Step | .github/workflows/test7.yml:49:9:59:6 | Run Step: benchmark-pr | Potential execution of untrusted code on a privileged workflow ($@) | .github/workflows/test7.yml:4:3:4:15 | issue_comment | issue_comment |
348+
| .github/workflows/test7.yml:59:9:59:30 | Run Step | .github/workflows/test7.yml:19:9:24:6 | Uses Step | .github/workflows/test7.yml:59:9:59:30 | Run Step | Potential execution of untrusted code on a privileged workflow ($@) | .github/workflows/test7.yml:4:3:4:15 | issue_comment | issue_comment |
346349
| .github/workflows/test10.yml:25:9:30:2 | Run Step | .github/workflows/test10.yml:20:9:25:6 | Uses Step | .github/workflows/test10.yml:25:9:30:2 | Run Step | Potential execution of untrusted code on a privileged workflow ($@) | .github/workflows/test10.yml:8:3:8:21 | pull_request_target | pull_request_target |
347350
| .github/workflows/test11.yml:90:7:93:54 | Uses Step | .github/workflows/test11.yml:84:7:90:4 | Uses Step | .github/workflows/test11.yml:90:7:93:54 | Uses Step | Potential execution of untrusted code on a privileged workflow ($@) | .github/workflows/test11.yml:5:3:5:15 | issue_comment | issue_comment |
348351
| .github/workflows/test17.yml:19:15:23:58 | Uses Step | .github/workflows/test17.yml:12:15:19:12 | Uses Step | .github/workflows/test17.yml:19:15:23:58 | Uses Step | Potential execution of untrusted code on a privileged workflow ($@) | .github/workflows/test17.yml:3:5:3:16 | workflow_run | workflow_run |

0 commit comments

Comments
 (0)