Skip to content

Commit f4ef434

Browse files
authored
Merge pull request #10558 from aschackmull/java/static-init-vector-perf
Java: Improve performance of StaticInitializationVector.
2 parents 257bcef + dcc3f9e commit f4ef434

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

java/ql/lib/semmle/code/java/security/StaticInitializationVectorQuery.qll

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import java
44
import semmle.code.java.dataflow.TaintTracking
5-
import semmle.code.java.dataflow.TaintTracking2
5+
import semmle.code.java.dataflow.DataFlow2
66

77
/**
88
* Holds if `array` is initialized only with constants.
@@ -83,14 +83,16 @@ private class ArrayUpdate extends Expr {
8383
/**
8484
* A config that tracks dataflow from creating an array to an operation that updates it.
8585
*/
86-
private class ArrayUpdateConfig extends TaintTracking2::Configuration {
86+
private class ArrayUpdateConfig extends DataFlow2::Configuration {
8787
ArrayUpdateConfig() { this = "ArrayUpdateConfig" }
8888

8989
override predicate isSource(DataFlow::Node source) {
9090
source.asExpr() instanceof StaticByteArrayCreation
9191
}
9292

9393
override predicate isSink(DataFlow::Node sink) { sink.asExpr() = any(ArrayUpdate upd).getArray() }
94+
95+
override predicate isBarrierOut(DataFlow::Node node) { this.isSink(node) }
9496
}
9597

9698
/**

0 commit comments

Comments
 (0)