Skip to content

Update search input style on project pages #16636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2023
Merged

Update search input style on project pages #16636

merged 1 commit into from
Mar 10, 2023

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Mar 2, 2023 •
edited
Loading

Description

Moving changes from #16499.

Minor follow up from #16439 to apply the same search input style on project pages, Branches & Prebuilds.

Release Notes

Update search input style on project pages

Documentation

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • leeway-no-cache
    leeway-target=components:all
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-slow-database
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@gtsiolis gtsiolis mentioned this pull request Mar 2, 2023
Closed
15 tasks
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Mar 2, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-preview=true

👍 started the job as gitpod-build-gt-update-search-inputs.1
(with .werft/ from main)

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Mar 2, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment=true with-preview=true recreate-vm=true

👍 started the job as gitpod-build-gt-update-search-inputs.2
(with .werft/ from main)

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Mar 2, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment=true with-preview=true recreate-vm=true

👍 started the job as gitpod-build-gt-update-search-inputs.4
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-gt-update-search-inputs.3 because the annotations in the pull request description changed
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-gt-update-search-inputs.5 because the annotations in the pull request description changed
(with .werft/ from main)

@gtsiolis gtsiolis force-pushed the gt/update-search-inputs branch 2 times, most recently from a5a900c to f77c43d Compare March 3, 2023 15:26
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Mar 3, 2023 •
edited by werft-gitpod-dev-com bot
Loading

One more attempt to spin up a preview environment. 🎲

/werft run with-preview

👍 started the job as gitpod-build-gt-update-search-inputs.8
(with .werft/ from main)

@gtsiolis gtsiolis force-pushed the gt/update-search-inputs branch 2 times, most recently from b459a82 to a26f35f Compare March 10, 2023 12:57
@gtsiolis gtsiolis force-pushed the gt/update-search-inputs branch from a26f35f to 6289838 Compare March 10, 2023 13:14
@gtsiolis gtsiolis marked this pull request as ready for review March 10, 2023 13:29
@gtsiolis gtsiolis requested a review from a team March 10, 2023 13:29
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Mar 10, 2023 •
edited
Loading

Ready-For-Review 🏓

There are a few minor spacing differences with the search input in dashboard vs. admin dashboard, but should be fine to merge this as is and tackle this separately with #16511. Cc @selfcontained

Admin (Users) Project (Branches) Admin (org)
admin-users project-branches admin-org

@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Mar 10, 2023
@roboquat roboquat merged commit 697c103 into main Mar 10, 2023
@roboquat roboquat deleted the gt/update-search-inputs branch March 10, 2023 13:33
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Mar 10, 2023 •
edited by werft-gitpod-dev-com bot
Loading

Thanks for taking a look, @easyCZ! 🌮 🌮

@gtsiolis gtsiolis mentioned this pull request Mar 10, 2023
Closed
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easyCZ easyCZ easyCZ approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gtsiolis @easyCZ @roboquat