Fix update user bug

lunny · lunny · commit 08f1f9d7812f · 2022-02-24T23:33:17.000+08:00
diff --git a/models/user/user.go b/models/user/user.go
@@ -868,13 +868,14 @@ func updateUser(ctx context.Context, u *User, changePrimaryEmail bool, cols ...s
 		}
 
 		if !primaryEmailExist {
-			_, err = e.Insert(&EmailAddress{
+			if _, err = e.Insert(&EmailAddress{
 				Email:       u.Email,
 				UID:         u.ID,
 				IsActivated: true,
 				IsPrimary:   true,
-			})
-			return err
+			}); err != nil {
+				return err
+			}
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -868,13 +868,14 @@ func updateUser(ctx context.Context, u *User, changePrimaryEmail bool, cols ...s`
`868`	`868`	`}`
`869`	`869`
`870`	`870`	`if !primaryEmailExist {`
`871`		`- _, err = e.Insert(&EmailAddress{`
	`871`	`+ if _, err = e.Insert(&EmailAddress{`
`872`	`872`	`Email: u.Email,`
`873`	`873`	`UID: u.ID,`
`874`	`874`	`IsActivated: true,`
`875`	`875`	`IsPrimary: true,`
`876`		`- })`
`877`		`- return err`
	`876`	`+ }); err != nil {`
	`877`	`+ return err`
	`878`	`+ }`
`878`	`879`	`}`
`879`	`880`	`}`
`880`	`881`