fix: close file in the Upload func (#30262)

testwill · web-flow · commit 0ceecfc11ab4 · 2024-04-03T10:58:13.000-04:00
diff --git a/modules/lfs/filesystem_client.go b/modules/lfs/filesystem_client.go
@@ -44,7 +44,7 @@ func (c *FilesystemClient) Download(ctx context.Context, objects []Pointer, call
 		if err != nil {
 			return err
 		}
-
+		defer f.Close()
 		if err := callback(p, f, nil); err != nil {
 			return err
 		}
@@ -75,7 +75,7 @@ func (c *FilesystemClient) Upload(ctx context.Context, objects []Pointer, callba
 			if err != nil {
 				return err
 			}
-
+			defer f.Close()
 			_, err = io.Copy(f, content)
 
 			return err

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ func (c *FilesystemClient) Download(ctx context.Context, objects []Pointer, call`
`44`	`44`	`if err != nil {`
`45`	`45`	`return err`
`46`	`46`	`}`
`47`		`-`
	`47`	`+ defer f.Close()`
`48`	`48`	`if err := callback(p, f, nil); err != nil {`
`49`	`49`	`return err`
`50`	`50`	`}`
`@@ -75,7 +75,7 @@ func (c *FilesystemClient) Upload(ctx context.Context, objects []Pointer, callba`
`75`	`75`	`if err != nil {`
`76`	`76`	`return err`
`77`	`77`	`}`
`78`		`-`
	`78`	`+ defer f.Close()`
`79`	`79`	`_, err = io.Copy(f, content)`
`80`	`80`
`81`	`81`	`return err`