Missed q.lock.Unlock() will cause panic (#9706)

zeripath · web-flow · commit 0e53a16cca32 · 2020-01-11T17:05:24.000Z
diff --git a/modules/queue/queue_wrapped.go b/modules/queue/queue_wrapped.go
@@ -62,7 +62,6 @@ func (q *delayedStarter) setInternal(atShutdown func(context.Context, func()), h
 			queue, err := NewQueue(q.underlying, handle, q.cfg, exemplar)
 			if err == nil {
 				q.internal = queue
-				q.lock.Unlock()
 				break
 			}
 			if err.Error() != "resource temporarily unavailable" {

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,6 @@ func (q *delayedStarter) setInternal(atShutdown func(context.Context, func()), h`
`62`	`62`	`queue, err := NewQueue(q.underlying, handle, q.cfg, exemplar)`
`63`	`63`	`if err == nil {`
`64`	`64`	`q.internal = queue`
`65`		`- q.lock.Unlock()`
`66`	`65`	`break`
`67`	`66`	`}`
`68`	`67`	`if err.Error() != "resource temporarily unavailable" {`