Skip to content

Commit 1bb9b1c

Browse files
authored
Remove polluted ".ui.left" style (#26809)
1 parent 2590707 commit 1bb9b1c

File tree

4 files changed

+5
-36
lines changed

4 files changed

+5
-36
lines changed

templates/repo/settings/collaboration.tmpl

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,8 @@
4141
<div class="ui bottom attached segment">
4242
<form class="ui form" id="repo-collab-form" action="{{.Link}}" method="post">
4343
{{.CsrfTokenHtml}}
44-
<div class="inline field ui left">
45-
<div id="search-user-box" class="ui search">
46-
<div class="ui input">
47-
<input class="prompt" name="collaborator" placeholder="{{.locale.Tr "repo.settings.search_user_placeholder"}}" autocomplete="off" autofocus required>
48-
</div>
49-
</div>
44+
<div id="search-user-box" class="ui search input gt-vm">
45+
<input class="prompt" name="collaborator" placeholder="{{.locale.Tr "repo.settings.search_user_placeholder"}}" autocomplete="off" autofocus required>
5046
</div>
5147
<button class="ui green button">{{.locale.Tr "repo.settings.add_collaborator"}}</button>
5248
</form>
@@ -93,12 +89,8 @@
9389
{{if $allowedToChangeTeams}}
9490
<form class="ui form" id="repo-collab-team-form" action="{{.Link}}/team" method="post">
9591
{{.CsrfTokenHtml}}
96-
<div class="inline field ui left">
97-
<div id="search-team-box" class="ui search" data-org="{{.OrgName}}">
98-
<div class="ui input">
99-
<input class="prompt" name="team" placeholder="{{$.locale.Tr "repo.settings.search_team"}}" autocomplete="off" autofocus required>
100-
</div>
101-
</div>
92+
<div id="search-team-box" class="ui search input gt-vm">
93+
<input class="prompt" name="team" placeholder="{{$.locale.Tr "repo.settings.search_team"}}" autocomplete="off" autofocus required>
10294
</div>
10395
<button class="ui green button">{{$.locale.Tr "repo.settings.add_team"}}</button>
10496
</form>

web_src/css/base.css

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1179,11 +1179,6 @@ img.ui.avatar,
11791179
font-size: 0.75em;
11801180
}
11811181

1182-
/* FIXME: this is a serious pollution, do not use this for "float: left" anymore */
1183-
.ui.left:not(.action) {
1184-
float: left;
1185-
}
1186-
11871182
/* FIXME: this is a serious pollution, do not use this for "float: right" anymore */
11881183
.ui.right:not(.action) {
11891184
float: right;

web_src/css/repo.css

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1907,24 +1907,6 @@
19071907
flex-wrap: wrap;
19081908
}
19091909

1910-
.repository.settings.collaboration #repo-collab-form #search-user-box .results {
1911-
left: 7px;
1912-
}
1913-
1914-
.repository.settings.collaboration #repo-collab-form .ui.button {
1915-
margin-left: 5px;
1916-
margin-top: -3px;
1917-
}
1918-
1919-
.repository.settings.collaboration #repo-collab-team-form #search-team-box .results {
1920-
left: 7px;
1921-
}
1922-
1923-
.repository.settings.collaboration #repo-collab-team-form .ui.button {
1924-
margin-left: 5px;
1925-
margin-top: -3px;
1926-
}
1927-
19281910
/* if the element is for a checkbox, then it should have a padding-left to align to the checkbox's text */
19291911
.repository.settings.branches .branch-protection .ui.checkbox .help,
19301912
.repository.settings.branches .branch-protection .checkbox-sub-item {

web_src/js/components/DashboardRepoList.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
</a>
1616
</h4>
1717
<div class="ui attached segment repos-search">
18-
<div class="ui fluid right action left icon input" :class="{loading: isLoading}">
18+
<div class="ui fluid action left icon input" :class="{loading: isLoading}">
1919
<input type="search" spellcheck="false" maxlength="255" @input="changeReposFilter(reposFilter)" v-model="searchQuery" ref="search" @keydown="reposFilterKeyControl" :placeholder="textSearchRepos">
2020
<i class="icon"><svg-icon name="octicon-search" :size="16"/></i>
2121
<div class="ui dropdown icon button" :title="textFilter">

0 commit comments

Comments
 (0)