Stop calling WriteHeader in Write (#15862)

zeripath · lafriks · web-flow · commit 2d87a84709cb · 2021-05-14T11:05:50.000+03:00
Fixes http: superfluous response.WriteHeader call from code.gitea.io/gitea/modules/context.(*Response).WriteHeader (response.go:67)

* Looking again we don't need this writeHeader as all of our downstream
implementations will always do it for us

Signed-off-by: Andrew Thornton &lt;art27@cantab.net&gt;
Co-authored-by: Lauris BH &lt;lauris@nix.lv&gt;
diff --git a/modules/context/response.go b/modules/context/response.go
@@ -49,7 +49,7 @@ func (r *Response) Write(bs []byte) (int, error) {
 		return size, err
 	}
 	if r.status == 0 {
-		r.WriteHeader(200)
+		r.status = http.StatusOK
 	}
 	return size, nil
 }

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ func (r *Response) Write(bs []byte) (int, error) {`
`49`	`49`	`return size, err`
`50`	`50`	`}`
`51`	`51`	`if r.status == 0 {`
`52`		`- r.WriteHeader(200)`
	`52`	`+ r.status = http.StatusOK`
`53`	`53`	`}`
`54`	`54`	`return size, nil`
`55`	`55`	`}`