Fix dropdown icon misalignment when using fomantic icon (#23558)

wxiaoguang · web-flow · commit 30668e0047d6 · 2023-03-18T22:24:26.000-04:00
There are still many dropdowns using fomantic icon. For example: new issue with issue template. Avoid polluting the fomantic styles. Before: ![image](https://user-images.githubusercontent.com/2114189/226101609-fa64178d-fed0-4541-bea2-72a250cb74db.png) After: ![image](https://user-images.githubusercontent.com/2114189/226101603-9507b275-fc5b-4a55-870d-db8c4486d80a.png)
diff --git a/web_src/css/base.css b/web_src/css/base.css
@@ -2540,10 +2540,10 @@ table th[data-sortt-desc] .svg {
   height: auto; /* reset the ".ui.dropdown > .dropdown.icon {height}", otherwise the icon would be too small */
 }
 
-.ui.selection.dropdown > .search.icon,
-.ui.selection.dropdown > .delete.icon,
-.ui.selection.dropdown > .dropdown.icon {
-  top: 0 !important;
+.ui.selection.dropdown > .svg.search.icon,
+.ui.selection.dropdown > .svg.delete.icon,
+.ui.selection.dropdown > .svg.dropdown.icon {
+  top: 0 !important; /* reset the ".ui.selection.dropdown > .xxx.icon {top}" if the icon is svg instead of the fomantic icon */
 }
 
 .ui.dropdown.no-text > .dropdown.icon {

Original file line number	Diff line number	Diff line change
`@@ -2540,10 +2540,10 @@ table th[data-sortt-desc] .svg {`
`2540`	`2540`	`height: auto; /* reset the ".ui.dropdown > .dropdown.icon {height}", otherwise the icon would be too small */`
`2541`	`2541`	`}`
`2542`	`2542`
`2543`		`-.ui.selection.dropdown > .search.icon,`
`2544`		`-.ui.selection.dropdown > .delete.icon,`
`2545`		`-.ui.selection.dropdown > .dropdown.icon {`
`2546`		`- top: 0 !important;`
	`2543`	`+.ui.selection.dropdown > .svg.search.icon,`
	`2544`	`+.ui.selection.dropdown > .svg.delete.icon,`
	`2545`	`+.ui.selection.dropdown > .svg.dropdown.icon {`
	`2546`	`+ top: 0 !important; /* reset the ".ui.selection.dropdown > .xxx.icon {top}" if the icon is svg instead of the fomantic icon */`
`2547`	`2547`	`}`
`2548`	`2548`
`2549`	`2549`	`.ui.dropdown.no-text > .dropdown.icon {`