Fixes #7945 - makes sure we are only getting tag refs (#7990)

richmahn · techknowlogick · commit 3302066f69b1 · 2019-08-26T23:11:24.000-04:00
diff --git a/modules/git/repo_tag.go b/modules/git/repo_tag.go
@@ -153,7 +153,7 @@ func (repo *Repository) GetTagNameBySHA(sha string) (string, error) {
 
 // GetTagID returns the object ID for a tag (annotated tags have both an object SHA AND a commit SHA)
 func (repo *Repository) GetTagID(name string) (string, error) {
-	stdout, err := NewCommand("show-ref", "--", name).RunInDir(repo.Path)
+	stdout, err := NewCommand("show-ref", "--tags", "--", name).RunInDir(repo.Path)
 	if err != nil {
 		return "", err
 	}

Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,7 @@ func (repo *Repository) GetTagNameBySHA(sha string) (string, error) {`
`153`	`153`
`154`	`154`	`// GetTagID returns the object ID for a tag (annotated tags have both an object SHA AND a commit SHA)`
`155`	`155`	`func (repo *Repository) GetTagID(name string) (string, error) {`
`156`		`- stdout, err := NewCommand("show-ref", "--", name).RunInDir(repo.Path)`
	`156`	`+ stdout, err := NewCommand("show-ref", "--tags", "--", name).RunInDir(repo.Path)`
`157`	`157`	`if err != nil {`
`158`	`158`	`return "", err`
`159`	`159`	`}`