Skip to content

Commit 352a2ca

Browse files
lunnyyp05327GiteaBot
authored
Performance improvements for pull request list API (#30490)
Fix #30483 --------- Co-authored-by: yp05327 <[email protected]> Co-authored-by: Giteabot <[email protected]>
1 parent 972f807 commit 352a2ca

File tree

12 files changed

+235
-122
lines changed

12 files changed

+235
-122
lines changed

‎models/issues/assignees.go

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,23 +27,27 @@ func init() {
2727

2828
// LoadAssignees load assignees of this issue.
2929
func (issue *Issue) LoadAssignees(ctx context.Context) (err error) {
30+
if issue.isAssigneeLoaded || len(issue.Assignees) > 0 {
31+
return nil
32+
}
33+
3034
// Reset maybe preexisting assignees
3135
issue.Assignees = []*user_model.User{}
3236
issue.Assignee = nil
3337

34-
err = db.GetEngine(ctx).Table("`user`").
38+
if err = db.GetEngine(ctx).Table("`user`").
3539
Join("INNER", "issue_assignees", "assignee_id = `user`.id").
3640
Where("issue_assignees.issue_id = ?", issue.ID).
37-
Find(&issue.Assignees)
38-
if err != nil {
41+
Find(&issue.Assignees); err != nil {
3942
return err
4043
}
4144

45+
issue.isAssigneeLoaded = true
4246
// Check if we have at least one assignee and if yes put it in as `Assignee`
4347
if len(issue.Assignees) > 0 {
4448
issue.Assignee = issue.Assignees[0]
4549
}
46-
return err
50+
return nil
4751
}
4852

4953
// GetAssigneeIDsByIssue returns the IDs of users assigned to an issue

‎models/issues/comment_list.go

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,19 +16,17 @@ import (
1616
// CommentList defines a list of comments
1717
type CommentList []*Comment
1818

19-
func (comments CommentList) getPosterIDs() []int64 {
20-
return container.FilterSlice(comments, func(c *Comment) (int64, bool) {
21-
return c.PosterID, c.PosterID > 0
22-
})
23-
}
24-
2519
// LoadPosters loads posters
2620
func (comments CommentList) LoadPosters(ctx context.Context) error {
2721
if len(comments) == 0 {
2822
return nil
2923
}
3024

31-
posterMaps, err := getPosters(ctx, comments.getPosterIDs())
25+
posterIDs := container.FilterSlice(comments, func(c *Comment) (int64, bool) {
26+
return c.PosterID, c.Poster == nil && c.PosterID > 0
27+
})
28+
29+
posterMaps, err := getPostersByIDs(ctx, posterIDs)
3230
if err != nil {
3331
return err
3432
}

‎models/issues/issue.go

Lines changed: 59 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -98,44 +98,48 @@ var ErrIssueAlreadyChanged = util.NewInvalidArgumentErrorf("the issue is already
9898

9999
// Issue represents an issue or pull request of repository.
100100
type Issue struct {
101-
ID int64 `xorm:"pk autoincr"`
102-
RepoID int64 `xorm:"INDEX UNIQUE(repo_index)"`
103-
Repo *repo_model.Repository `xorm:"-"`
104-
Index int64 `xorm:"UNIQUE(repo_index)"` // Index in one repository.
105-
PosterID int64 `xorm:"INDEX"`
106-
Poster *user_model.User `xorm:"-"`
107-
OriginalAuthor string
108-
OriginalAuthorID int64 `xorm:"index"`
109-
Title string `xorm:"name"`
110-
Content string `xorm:"LONGTEXT"`
111-
RenderedContent template.HTML `xorm:"-"`
112-
ContentVersion int `xorm:"NOT NULL DEFAULT 0"`
113-
Labels []*Label `xorm:"-"`
114-
MilestoneID int64 `xorm:"INDEX"`
115-
Milestone *Milestone `xorm:"-"`
116-
Project *project_model.Project `xorm:"-"`
117-
Priority int
118-
AssigneeID int64 `xorm:"-"`
119-
Assignee *user_model.User `xorm:"-"`
120-
IsClosed bool `xorm:"INDEX"`
121-
IsRead bool `xorm:"-"`
122-
IsPull bool `xorm:"INDEX"` // Indicates whether is a pull request or not.
123-
PullRequest *PullRequest `xorm:"-"`
124-
NumComments int
125-
Ref string
126-
PinOrder int `xorm:"DEFAULT 0"`
101+
ID int64 `xorm:"pk autoincr"`
102+
RepoID int64 `xorm:"INDEX UNIQUE(repo_index)"`
103+
Repo *repo_model.Repository `xorm:"-"`
104+
Index int64 `xorm:"UNIQUE(repo_index)"` // Index in one repository.
105+
PosterID int64 `xorm:"INDEX"`
106+
Poster *user_model.User `xorm:"-"`
107+
OriginalAuthor string
108+
OriginalAuthorID int64 `xorm:"index"`
109+
Title string `xorm:"name"`
110+
Content string `xorm:"LONGTEXT"`
111+
RenderedContent template.HTML `xorm:"-"`
112+
ContentVersion int `xorm:"NOT NULL DEFAULT 0"`
113+
Labels []*Label `xorm:"-"`
114+
isLabelsLoaded bool `xorm:"-"`
115+
MilestoneID int64 `xorm:"INDEX"`
116+
Milestone *Milestone `xorm:"-"`
117+
isMilestoneLoaded bool `xorm:"-"`
118+
Project *project_model.Project `xorm:"-"`
119+
Priority int
120+
AssigneeID int64 `xorm:"-"`
121+
Assignee *user_model.User `xorm:"-"`
122+
isAssigneeLoaded bool `xorm:"-"`
123+
IsClosed bool `xorm:"INDEX"`
124+
IsRead bool `xorm:"-"`
125+
IsPull bool `xorm:"INDEX"` // Indicates whether is a pull request or not.
126+
PullRequest *PullRequest `xorm:"-"`
127+
NumComments int
128+
Ref string
129+
PinOrder int `xorm:"DEFAULT 0"`
127130

128131
DeadlineUnix timeutil.TimeStamp `xorm:"INDEX"`
129132

130133
CreatedUnix timeutil.TimeStamp `xorm:"INDEX created"`
131134
UpdatedUnix timeutil.TimeStamp `xorm:"INDEX updated"`
132135
ClosedUnix timeutil.TimeStamp `xorm:"INDEX"`
133136

134-
Attachments []*repo_model.Attachment `xorm:"-"`
135-
Comments CommentList `xorm:"-"`
136-
Reactions ReactionList `xorm:"-"`
137-
TotalTrackedTime int64 `xorm:"-"`
138-
Assignees []*user_model.User `xorm:"-"`
137+
Attachments []*repo_model.Attachment `xorm:"-"`
138+
isAttachmentsLoaded bool `xorm:"-"`
139+
Comments CommentList `xorm:"-"`
140+
Reactions ReactionList `xorm:"-"`
141+
TotalTrackedTime int64 `xorm:"-"`
142+
Assignees []*user_model.User `xorm:"-"`
139143

140144
// IsLocked limits commenting abilities to users on an issue
141145
// with write access
@@ -187,6 +191,19 @@ func (issue *Issue) LoadRepo(ctx context.Context) (err error) {
187191
return nil
188192
}
189193

194+
func (issue *Issue) LoadAttachments(ctx context.Context) (err error) {
195+
if issue.isAttachmentsLoaded || issue.Attachments != nil {
196+
return nil
197+
}
198+
199+
issue.Attachments, err = repo_model.GetAttachmentsByIssueID(ctx, issue.ID)
200+
if err != nil {
201+
return fmt.Errorf("getAttachmentsByIssueID [%d]: %w", issue.ID, err)
202+
}
203+
issue.isAttachmentsLoaded = true
204+
return nil
205+
}
206+
190207
// IsTimetrackerEnabled returns true if the repo enables timetracking
191208
func (issue *Issue) IsTimetrackerEnabled(ctx context.Context) bool {
192209
if err := issue.LoadRepo(ctx); err != nil {
@@ -287,11 +304,12 @@ func (issue *Issue) loadReactions(ctx context.Context) (err error) {
287304

288305
// LoadMilestone load milestone of this issue.
289306
func (issue *Issue) LoadMilestone(ctx context.Context) (err error) {
290-
if (issue.Milestone == nil || issue.Milestone.ID != issue.MilestoneID) && issue.MilestoneID > 0 {
307+
if !issue.isMilestoneLoaded && (issue.Milestone == nil || issue.Milestone.ID != issue.MilestoneID) && issue.MilestoneID > 0 {
291308
issue.Milestone, err = GetMilestoneByRepoID(ctx, issue.RepoID, issue.MilestoneID)
292309
if err != nil && !IsErrMilestoneNotExist(err) {
293310
return fmt.Errorf("getMilestoneByRepoID [repo_id: %d, milestone_id: %d]: %w", issue.RepoID, issue.MilestoneID, err)
294311
}
312+
issue.isMilestoneLoaded = true
295313
}
296314
return nil
297315
}
@@ -327,11 +345,8 @@ func (issue *Issue) LoadAttributes(ctx context.Context) (err error) {
327345
return err
328346
}
329347

330-
if issue.Attachments == nil {
331-
issue.Attachments, err = repo_model.GetAttachmentsByIssueID(ctx, issue.ID)
332-
if err != nil {
333-
return fmt.Errorf("getAttachmentsByIssueID [%d]: %w", issue.ID, err)
334-
}
348+
if err = issue.LoadAttachments(ctx); err != nil {
349+
return err
335350
}
336351

337352
if err = issue.loadComments(ctx); err != nil {
@@ -350,6 +365,13 @@ func (issue *Issue) LoadAttributes(ctx context.Context) (err error) {
350365
return issue.loadReactions(ctx)
351366
}
352367

368+
func (issue *Issue) ResetAttributesLoaded() {
369+
issue.isLabelsLoaded = false
370+
issue.isMilestoneLoaded = false
371+
issue.isAttachmentsLoaded = false
372+
issue.isAssigneeLoaded = false
373+
}
374+
353375
// GetIsRead load the `IsRead` field of the issue
354376
func (issue *Issue) GetIsRead(ctx context.Context, userID int64) error {
355377
issueUser := &IssueUser{IssueID: issue.ID, UID: userID}

‎models/issues/issue_label.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,7 @@ func NewIssueLabel(ctx context.Context, issue *Issue, label *Label, doer *user_m
111111
return err
112112
}
113113

114+
issue.isLabelsLoaded = false
114115
issue.Labels = nil
115116
if err = issue.LoadLabels(ctx); err != nil {
116117
return err
@@ -160,6 +161,8 @@ func NewIssueLabels(ctx context.Context, issue *Issue, labels []*Label, doer *us
160161
return err
161162
}
162163

164+
// reload all labels
165+
issue.isLabelsLoaded = false
163166
issue.Labels = nil
164167
if err = issue.LoadLabels(ctx); err != nil {
165168
return err
@@ -325,11 +328,12 @@ func FixIssueLabelWithOutsideLabels(ctx context.Context) (int64, error) {
325328

326329
// LoadLabels loads labels
327330
func (issue *Issue) LoadLabels(ctx context.Context) (err error) {
328-
if issue.Labels == nil && issue.ID != 0 {
331+
if !issue.isLabelsLoaded && issue.Labels == nil && issue.ID != 0 {
329332
issue.Labels, err = GetLabelsByIssueID(ctx, issue.ID)
330333
if err != nil {
331334
return fmt.Errorf("getLabelsByIssueID [%d]: %w", issue.ID, err)
332335
}
336+
issue.isLabelsLoaded = true
333337
}
334338
return nil
335339
}

‎models/issues/issue_list.go

Lines changed: 26 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -72,18 +72,16 @@ func (issues IssueList) LoadRepositories(ctx context.Context) (repo_model.Reposi
7272
return repo_model.ValuesRepository(repoMaps), nil
7373
}
7474

75-
func (issues IssueList) getPosterIDs() []int64 {
76-
return container.FilterSlice(issues, func(issue *Issue) (int64, bool) {
77-
return issue.PosterID, true
78-
})
79-
}
80-
81-
func (issues IssueList) loadPosters(ctx context.Context) error {
75+
func (issues IssueList) LoadPosters(ctx context.Context) error {
8276
if len(issues) == 0 {
8377
return nil
8478
}
8579

86-
posterMaps, err := getPosters(ctx, issues.getPosterIDs())
80+
posterIDs := container.FilterSlice(issues, func(issue *Issue) (int64, bool) {
81+
return issue.PosterID, issue.Poster == nil && issue.PosterID > 0
82+
})
83+
84+
posterMaps, err := getPostersByIDs(ctx, posterIDs)
8785
if err != nil {
8886
return err
8987
}
@@ -94,7 +92,7 @@ func (issues IssueList) loadPosters(ctx context.Context) error {
9492
return nil
9593
}
9694

97-
func getPosters(ctx context.Context, posterIDs []int64) (map[int64]*user_model.User, error) {
95+
func getPostersByIDs(ctx context.Context, posterIDs []int64) (map[int64]*user_model.User, error) {
9896
posterMaps := make(map[int64]*user_model.User, len(posterIDs))
9997
left := len(posterIDs)
10098
for left > 0 {
@@ -136,7 +134,7 @@ func (issues IssueList) getIssueIDs() []int64 {
136134
return ids
137135
}
138136

139-
func (issues IssueList) loadLabels(ctx context.Context) error {
137+
func (issues IssueList) LoadLabels(ctx context.Context) error {
140138
if len(issues) == 0 {
141139
return nil
142140
}
@@ -168,7 +166,7 @@ func (issues IssueList) loadLabels(ctx context.Context) error {
168166
err = rows.Scan(&labelIssue)
169167
if err != nil {
170168
if err1 := rows.Close(); err1 != nil {
171-
return fmt.Errorf("IssueList.loadLabels: Close: %w", err1)
169+
return fmt.Errorf("IssueList.LoadLabels: Close: %w", err1)
172170
}
173171
return err
174172
}
@@ -177,14 +175,15 @@ func (issues IssueList) loadLabels(ctx context.Context) error {
177175
// When there are no rows left and we try to close it.
178176
// Since that is not relevant for us, we can safely ignore it.
179177
if err1 := rows.Close(); err1 != nil {
180-
return fmt.Errorf("IssueList.loadLabels: Close: %w", err1)
178+
return fmt.Errorf("IssueList.LoadLabels: Close: %w", err1)
181179
}
182180
left -= limit
183181
issueIDs = issueIDs[limit:]
184182
}
185183

186184
for _, issue := range issues {
187185
issue.Labels = issueLabels[issue.ID]
186+
issue.isLabelsLoaded = true
188187
}
189188
return nil
190189
}
@@ -195,7 +194,7 @@ func (issues IssueList) getMilestoneIDs() []int64 {
195194
})
196195
}
197196

198-
func (issues IssueList) loadMilestones(ctx context.Context) error {
197+
func (issues IssueList) LoadMilestones(ctx context.Context) error {
199198
milestoneIDs := issues.getMilestoneIDs()
200199
if len(milestoneIDs) == 0 {
201200
return nil
@@ -220,6 +219,7 @@ func (issues IssueList) loadMilestones(ctx context.Context) error {
220219

221220
for _, issue := range issues {
222221
issue.Milestone = milestoneMaps[issue.MilestoneID]
222+
issue.isMilestoneLoaded = true
223223
}
224224
return nil
225225
}
@@ -263,7 +263,7 @@ func (issues IssueList) LoadProjects(ctx context.Context) error {
263263
return nil
264264
}
265265

266-
func (issues IssueList) loadAssignees(ctx context.Context) error {
266+
func (issues IssueList) LoadAssignees(ctx context.Context) error {
267267
if len(issues) == 0 {
268268
return nil
269269
}
@@ -310,6 +310,10 @@ func (issues IssueList) loadAssignees(ctx context.Context) error {
310310

311311
for _, issue := range issues {
312312
issue.Assignees = assignees[issue.ID]
313+
if len(issue.Assignees) > 0 {
314+
issue.Assignee = issue.Assignees[0]
315+
}
316+
issue.isAssigneeLoaded = true
313317
}
314318
return nil
315319
}
@@ -413,6 +417,7 @@ func (issues IssueList) LoadAttachments(ctx context.Context) (err error) {
413417

414418
for _, issue := range issues {
415419
issue.Attachments = attachments[issue.ID]
420+
issue.isAttachmentsLoaded = true
416421
}
417422
return nil
418423
}
@@ -538,23 +543,23 @@ func (issues IssueList) LoadAttributes(ctx context.Context) error {
538543
return fmt.Errorf("issue.loadAttributes: LoadRepositories: %w", err)
539544
}
540545

541-
if err := issues.loadPosters(ctx); err != nil {
542-
return fmt.Errorf("issue.loadAttributes: loadPosters: %w", err)
546+
if err := issues.LoadPosters(ctx); err != nil {
547+
return fmt.Errorf("issue.loadAttributes: LoadPosters: %w", err)
543548
}
544549

545-
if err := issues.loadLabels(ctx); err != nil {
546-
return fmt.Errorf("issue.loadAttributes: loadLabels: %w", err)
550+
if err := issues.LoadLabels(ctx); err != nil {
551+
return fmt.Errorf("issue.loadAttributes: LoadLabels: %w", err)
547552
}
548553

549-
if err := issues.loadMilestones(ctx); err != nil {
550-
return fmt.Errorf("issue.loadAttributes: loadMilestones: %w", err)
554+
if err := issues.LoadMilestones(ctx); err != nil {
555+
return fmt.Errorf("issue.loadAttributes: LoadMilestones: %w", err)
551556
}
552557

553558
if err := issues.LoadProjects(ctx); err != nil {
554559
return fmt.Errorf("issue.loadAttributes: loadProjects: %w", err)
555560
}
556561

557-
if err := issues.loadAssignees(ctx); err != nil {
562+
if err := issues.LoadAssignees(ctx); err != nil {
558563
return fmt.Errorf("issue.loadAttributes: loadAssignees: %w", err)
559564
}
560565

0 commit comments

Comments
 (0)