Skip to content

Commit 49c5fc5

Browse files
author
Gusted
authored
Fix NPE /repos/issues/search when not signed in (#19154)
- Don't panic when on `/repos/issues/search?{created,assigned,mentioned,review_requested}=true` when client didn't pass any authentication. - Resolves #19115
1 parent 83a2f79 commit 49c5fc5

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

routers/api/v1/repo/issue.go

+9-4
Original file line numberDiff line numberDiff line change
@@ -245,18 +245,23 @@ func SearchIssues(ctx *context.APIContext) {
245245
UpdatedAfterUnix: since,
246246
}
247247

248+
ctxUserID := int64(0)
249+
if ctx.IsSigned {
250+
ctxUserID = ctx.User.ID
251+
}
252+
248253
// Filter for: Created by User, Assigned to User, Mentioning User, Review of User Requested
249254
if ctx.FormBool("created") {
250-
issuesOpt.PosterID = ctx.User.ID
255+
issuesOpt.PosterID = ctxUserID
251256
}
252257
if ctx.FormBool("assigned") {
253-
issuesOpt.AssigneeID = ctx.User.ID
258+
issuesOpt.AssigneeID = ctxUserID
254259
}
255260
if ctx.FormBool("mentioned") {
256-
issuesOpt.MentionedID = ctx.User.ID
261+
issuesOpt.MentionedID = ctxUserID
257262
}
258263
if ctx.FormBool("review_requested") {
259-
issuesOpt.ReviewRequestedID = ctx.User.ID
264+
issuesOpt.ReviewRequestedID = ctxUserID
260265
}
261266

262267
if issues, err = models.Issues(issuesOpt); err != nil {

0 commit comments

Comments
 (0)