Skip to content

Commit 5d3dbff

Browse files
author
Gusted
authored
Return 404 when user is not found on avatar (#21476)
- Instead of returning a 500 Internal Server when the user wasn't found, return 404 Not found
1 parent 11d3677 commit 5d3dbff

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

routers/web/user/avatar.go

+4
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,10 @@ func AvatarByUserName(ctx *context.Context) {
3131
if strings.ToLower(userName) != "ghost" {
3232
var err error
3333
if user, err = user_model.GetUserByName(ctx, userName); err != nil {
34+
if user_model.IsErrUserNotExist(err) {
35+
ctx.NotFound("GetUserByName", err)
36+
return
37+
}
3438
ctx.ServerError("Invalid user: "+userName, err)
3539
return
3640
}

0 commit comments

Comments
 (0)