Skip to content

Commit 5e2bae7

Browse files
GiteaBotwxiaoguang
andauthored
Don't show unnecessary citation JS error on UI (#28433) (#28437)
Backport #28433 by wxiaoguang Fix #28226 Co-authored-by: wxiaoguang <[email protected]>
1 parent 96d3fcf commit 5e2bae7

File tree

1 file changed

+11
-4
lines changed

1 file changed

+11
-4
lines changed

web_src/js/features/citation.js

+11-4
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import $ from 'jquery';
22

33
const {pageData} = window.config;
44

5-
const initInputCitationValue = async ($citationCopyApa, $citationCopyBibtex) => {
5+
async function initInputCitationValue($citationCopyApa, $citationCopyBibtex) {
66
const [{Cite, plugins}] = await Promise.all([
77
import(/* webpackChunkName: "citation-js-core" */'@citation-js/core'),
88
import(/* webpackChunkName: "citation-js-formats" */'@citation-js/plugin-software-formats'),
@@ -19,9 +19,9 @@ const initInputCitationValue = async ($citationCopyApa, $citationCopyBibtex) =>
1919
const bibtexOutput = citationFormatter.format('bibtex', {lang});
2020
$citationCopyBibtex.attr('data-text', bibtexOutput);
2121
$citationCopyApa.attr('data-text', apaOutput);
22-
};
22+
}
2323

24-
export function initCitationFileCopyContent() {
24+
export async function initCitationFileCopyContent() {
2525
const defaultCitationFormat = 'apa'; // apa or bibtex
2626

2727
if (!pageData.citationFileContent) return;
@@ -39,7 +39,14 @@ export function initCitationFileCopyContent() {
3939
$citationCopyBibtex.toggleClass('primary', isBibtex);
4040
$citationCopyApa.toggleClass('primary', !isBibtex);
4141
};
42-
initInputCitationValue($citationCopyApa, $citationCopyBibtex).then(updateUi);
42+
43+
try {
44+
await initInputCitationValue($citationCopyApa, $citationCopyBibtex);
45+
} catch (e) {
46+
console.error(`initCitationFileCopyContent error: ${e}`, e);
47+
return;
48+
}
49+
updateUi();
4350

4451
$citationCopyApa.on('click', () => {
4552
localStorage.setItem('citation-copy-format', 'apa');

0 commit comments

Comments
 (0)