Skip to content

Commit 6767798

Browse files
authored
Move editorconfig-checker to lint-backend and remove JS wrapper (#18793)
* Move editorconfig-checker to lint-backend It makes more sense there as templates are considered backend code. * User golang version of the tool * remove dependency
1 parent 833f291 commit 6767798

File tree

3 files changed

+8
-234
lines changed

3 files changed

+8
-234
lines changed

Makefile

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -313,10 +313,9 @@ lint: lint-frontend lint-backend
313313
lint-frontend: node_modules
314314
npx eslint --color --max-warnings=0 web_src/js build templates *.config.js docs/assets/js
315315
npx stylelint --color --max-warnings=0 web_src/less
316-
npx editorconfig-checker templates
317316

318317
.PHONY: lint-backend
319-
lint-backend: golangci-lint vet
318+
lint-backend: golangci-lint vet editorconfig-checker
320319

321320
.PHONY: watch
322321
watch:
@@ -789,6 +788,13 @@ golangci-lint-check:
789788
curl -sfL "https://raw.githubusercontent.com/golangci/golangci-lint/v${MIN_GOLANGCI_LINT_VER_FMT}/install.sh" | sh -s -- -b $(GOPATH)/bin v$(MIN_GOLANGCI_LINT_VER_FMT); \
790789
fi
791790

791+
.PHONY: editorconfig-checker
792+
editorconfig-checker:
793+
@hash editorconfig-checker > /dev/null 2>&1; if [ $$? -ne 0 ]; then \
794+
$(GO) install github.com/editorconfig-checker/editorconfig-checker/cmd/editorconfig-checker@50adf46752da119dfef66e57be3ce2693ea4aa9c; \
795+
fi
796+
editorconfig-checker templates
797+
792798
.PHONY: docker
793799
docker:
794800
docker build --disable-content-trust=false -t $(DOCKER_REF) .

package-lock.json

Lines changed: 0 additions & 231 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@
4545
"wrap-ansi": "8.0.1"
4646
},
4747
"devDependencies": {
48-
"editorconfig-checker": "4.0.2",
4948
"eslint": "8.8.0",
5049
"eslint-plugin-html": "6.2.0",
5150
"eslint-plugin-import": "2.25.4",

0 commit comments

Comments
 (0)