Apply suggestions from code review

6543 · web-flow · commit 6958874cb31c · 2021-07-14T12:01:08.000+02:00
diff --git a/cmd/serv.go b/cmd/serv.go
@@ -73,6 +73,8 @@ var (
 )
 
 func fail(userMessage, logMessage string, args ...interface{}) error {
+	// There appears to be a chance to cause a zombie process and failure to read the Exit status
+	// if nothing is outputted on stdout.
 	fmt.Fprintln(os.Stdout, "")
 	fmt.Fprintln(os.Stderr, "Gitea:", userMessage)
 

Original file line number	Diff line number	Diff line change
`@@ -73,6 +73,8 @@ var (`
`73`	`73`	`)`
`74`	`74`
`75`	`75`	`func fail(userMessage, logMessage string, args ...interface{}) error {`
	`76`	`+ // There appears to be a chance to cause a zombie process and failure to read the Exit status`
	`77`	`+ // if nothing is outputted on stdout.`
`76`	`78`	`fmt.Fprintln(os.Stdout, "")`
`77`	`79`	`fmt.Fprintln(os.Stderr, "Gitea:", userMessage)`
`78`	`80`