Skip to content

Commit 696a120

Browse files
committed
add a comment of annoying Chrome crash for future developers, fix lint
1 parent f0153a3 commit 696a120

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

web_src/js/features/aria.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ function attachOneDropdownAria($dropdown) {
9191

9292
// if there is an active item, use it (the user is navigating between items)
9393
// otherwise use the "selected" for combobox (for the last selected item)
94-
let $active = $menu.find('> .item.active, > .item.selected');
94+
const $active = $menu.find('> .item.active, > .item.selected');
9595

9696
// if there is an active item, use its id. if no active item or the dropdown is used as menu and is hidden, empty the active item
9797
const activeId = $active.attr('id');

web_src/js/features/common-global.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,8 @@ export function initGlobalCommon() {
9191
const $uiDropdowns = $('.ui.dropdown');
9292

9393
// do not init "custom" dropdowns, "custom" dropdowns are managed by their own code.
94+
// NOTICE: some old Android Chrome browsers has a crash bug, this line triggers the bug,
95+
// the browser crashes when users click the Issue Reaction Menu button ("return" before this line, no crash. after, crash)
9496
$uiDropdowns.filter(':not(.custom)').dropdown({fullTextSearch: 'exact'});
9597

9698
// The "jump" means this dropdown is mainly used for "menu" purpose,

0 commit comments

Comments
 (0)