Fix issue will be detected as pull request when checking First-time contributor (#28237) (#28271)

GiteaBot · yp05327 · web-flow · commit 76e892317b22 · 2023-11-29T02:49:33.000Z
Backport #28237 by @yp05327 Fix #28224 Co-authored-by: yp05327 <576951401@qq.com>
diff --git a/routers/web/repo/issue.go b/routers/web/repo/issue.go
@@ -1306,7 +1306,7 @@ func roleDescriptor(ctx stdCtx.Context, repo *repo_model.Repository, poster *use
 		return roleDescriptor, err
 	} else if hasMergedPR {
 		roleDescriptor.RoleInRepo = issues_model.RoleRepoContributor
-	} else {
+	} else if issue.IsPull {
 		// only display first time contributor in the first opening pull request
 		roleDescriptor.RoleInRepo = issues_model.RoleRepoFirstTimeContributor
 	}

Original file line number	Diff line number	Diff line change
`@@ -1306,7 +1306,7 @@ func roleDescriptor(ctx stdCtx.Context, repo repo_model.Repository, poster use`
`1306`	`1306`	`return roleDescriptor, err`
`1307`	`1307`	`} else if hasMergedPR {`
`1308`	`1308`	`roleDescriptor.RoleInRepo = issues_model.RoleRepoContributor`
`1309`		`- } else {`
	`1309`	`+ } else if issue.IsPull {`
`1310`	`1310`	`// only display first time contributor in the first opening pull request`
`1311`	`1311`	`roleDescriptor.RoleInRepo = issues_model.RoleRepoFirstTimeContributor`
`1312`	`1312`	`}`