Skip to content

Commit 7d1770c

Browse files
Gustedlunny
Gusted
andauthored
Use correct count for NumOpenIssues (#19980)
- Don't specify the field in `Count` instead use `Cols` for this. - Call `log.Error` when a error occur. Co-authored-by: Lunny Xiao <[email protected]>
1 parent 6473bd3 commit 7d1770c

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

models/project/issue.go

+7-1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import (
99
"fmt"
1010

1111
"code.gitea.io/gitea/models/db"
12+
"code.gitea.io/gitea/modules/log"
1213
)
1314

1415
// ProjectIssue saves relation from issue to a project
@@ -41,6 +42,7 @@ func (p *Project) NumIssues() int {
4142
Cols("issue_id").
4243
Count()
4344
if err != nil {
45+
log.Error("NumIssues: %v", err)
4446
return 0
4547
}
4648
return int(c)
@@ -54,6 +56,7 @@ func (p *Project) NumClosedIssues() int {
5456
Cols("issue_id").
5557
Count()
5658
if err != nil {
59+
log.Error("NumClosedIssues: %v", err)
5760
return 0
5861
}
5962
return int(c)
@@ -63,8 +66,11 @@ func (p *Project) NumClosedIssues() int {
6366
func (p *Project) NumOpenIssues() int {
6467
c, err := db.GetEngine(db.DefaultContext).Table("project_issue").
6568
Join("INNER", "issue", "project_issue.issue_id=issue.id").
66-
Where("project_issue.project_id=? AND issue.is_closed=?", p.ID, false).Count("issue.id")
69+
Where("project_issue.project_id=? AND issue.is_closed=?", p.ID, false).
70+
Cols("issue_id").
71+
Count()
6772
if err != nil {
73+
log.Error("NumOpenIssues: %v", err)
6874
return 0
6975
}
7076
return int(c)

0 commit comments

Comments
 (0)