add missing token validation and fix missing alert on application settings page (#3976)

daviian · lunny · commit 80d199898125 · 2018-05-16T22:18:13.000+08:00
diff --git a/modules/auth/user_form.go b/modules/auth/user_form.go
@@ -184,7 +184,7 @@ func (f *AddKeyForm) Validate(ctx *macaron.Context, errs binding.Errors) binding
 
 // NewAccessTokenForm form for creating access token
 type NewAccessTokenForm struct {
-	Name string `binding:"Required"`
+	Name string `binding:"Required;MaxSize(255)"`
 }
 
 // Validate valideates the fields
diff --git a/templates/user/settings/applications.tmpl b/templates/user/settings/applications.tmpl
@@ -2,6 +2,7 @@
 <div class="user settings applications">
 	{{template "user/settings/navbar" .}}
 	<div class="ui container">
+		{{template "base/alert" .}}
 		<h4 class="ui top attached header">
 			{{.i18n.Tr "settings.manage_access_token"}}
 		</h4>

Original file line number	Diff line number	Diff line change
`@@ -184,7 +184,7 @@ func (f AddKeyForm) Validate(ctx macaron.Context, errs binding.Errors) binding`
`184`	`184`
`185`	`185`	`// NewAccessTokenForm form for creating access token`
`186`	`186`	`type NewAccessTokenForm struct {`
`187`		- Name string `binding:"Required"`
	`187`	+ Name string `binding:"Required;MaxSize(255)"`
`188`	`188`	`}`
`189`	`189`
`190`	`190`	`// Validate valideates the fields`