Skip to content

Commit 839cd26

Browse files
authored
Add -F to commit search to treat keywords as strings (#28744)
Fixes #28269 The [default behavior](https://git-scm.com/docs/git-log#Documentation/git-log.txt---basic-regexp) of --grep in git log is to interpret the keyword as a regular expression. This causes the search to fail in the cases where the search keyword contains a `[`, since `[` is a special character used in grep. If we want our keywords to be interpreted as 'strings', we should use [-F flag](https://git-scm.com/docs/git-log#Documentation/git-log.txt---basic-regexp).
1 parent 2df7563 commit 839cd26

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

modules/git/repo_commit.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,9 @@ func (repo *Repository) searchCommits(id ObjectID, opts SearchCommitsOptions) ([
142142
cmd.AddArguments("--all")
143143
}
144144

145+
// interpret search string keywords as string instead of regex
146+
cmd.AddArguments("-F")
147+
145148
// add remaining keywords from search string
146149
// note this is done only for command created above
147150
for _, v := range opts.Keywords {

0 commit comments

Comments
 (0)