Fix issue will be detected as pull request when checking First-time contributor (#28237)

yp05327 · web-flow · commit 8572e71a7f0d · 2023-11-27T10:46:55.000Z
Fix #28224
diff --git a/routers/web/repo/issue.go b/routers/web/repo/issue.go
@@ -1319,7 +1319,7 @@ func roleDescriptor(ctx stdCtx.Context, repo *repo_model.Repository, poster *use
 		return roleDescriptor, err
 	} else if hasMergedPR {
 		roleDescriptor.RoleInRepo = issues_model.RoleRepoContributor
-	} else {
+	} else if issue.IsPull {
 		// only display first time contributor in the first opening pull request
 		roleDescriptor.RoleInRepo = issues_model.RoleRepoFirstTimeContributor
 	}

Original file line number	Diff line number	Diff line change
`@@ -1319,7 +1319,7 @@ func roleDescriptor(ctx stdCtx.Context, repo repo_model.Repository, poster use`
`1319`	`1319`	`return roleDescriptor, err`
`1320`	`1320`	`} else if hasMergedPR {`
`1321`	`1321`	`roleDescriptor.RoleInRepo = issues_model.RoleRepoContributor`
`1322`		`- } else {`
	`1322`	`+ } else if issue.IsPull {`
`1323`	`1323`	`// only display first time contributor in the first opening pull request`
`1324`	`1324`	`roleDescriptor.RoleInRepo = issues_model.RoleRepoFirstTimeContributor`
`1325`	`1325`	`}`