Create functions in the service layer to change the visibility

Author: fabiobarkoski

routers/web/repo/setting/setting.go

@@ -947,8 +947,15 @@ func SettingsPost(ctx *context.Context) {
 			return
 		}
 
-		repo.IsPrivate = !repo.IsPrivate
-		if err := repo_service.UpdateRepository(ctx, repo, true); err != nil {
+		var err error
+
+		if repo.IsPrivate {
+			err = repo_service.MakeRepoPublic(ctx, repo)
+		} else {
+			err = repo_service.MakeRepoPrivate(ctx, repo)
+		}
+
+		if err != nil {
 			log.Error("Tried to change the visibility of the repo: %s", err)
 			ctx.Flash.Error(ctx.Tr("repo.settings.visibility.error"))
 			ctx.Redirect(ctx.Repo.RepoLink + "/settings")

services/repository/repository.go

@@ -122,6 +122,31 @@ func UpdateRepository(ctx context.Context, repo *repo_model.Repository, visibili
 	return committer.Commit()
 }
 
+func UpdateRepositoryVisibility(ctx context.Context, repo *repo_model.Repository, IsPrivate bool) (err error) {
+	ctx, committer, err := db.TxContext(ctx)
+	if err != nil {
+		return err
+	}
+
+	defer committer.Close()
+
+	repo.IsPrivate = IsPrivate
+
+	if err = repo_module.UpdateRepository(ctx, repo, true); err != nil {
+		return fmt.Errorf("UpdateRepositoryVisibility: %w", err)
+	}
+
+	return committer.Commit()
+}
+
+func MakeRepoPublic(ctx context.Context, repo *repo_model.Repository) (err error) {
+	return UpdateRepositoryVisibility(ctx, repo, false)
+}
+
+func MakeRepoPrivate(ctx context.Context, repo *repo_model.Repository) (err error) {
+	return UpdateRepositoryVisibility(ctx, repo, true)
+}
+
 // LinkedRepository returns the linked repo if any
 func LinkedRepository(ctx context.Context, a *repo_model.Attachment) (*repo_model.Repository, unit.Type, error) {
 	if a.IssueID != 0 {