Skip to content

Commit 89becee

Browse files
authored
Fix a UI error when folding a file content in a commit view (#17446)
1 parent a462fca commit 89becee

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

templates/repo/diff/box.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@
5959
{{$showFileViewToggle := or $isImage (and (not $file.IsIncomplete) $isCsv)}}
6060
<div class="diff-file-box diff-box file-content {{TabSizeClass $.Editorconfig $file.Name}} mt-3" id="diff-{{.Index}}" data-old-filename="{{$file.OldName}}" data-new-filename="{{$file.Name}}" {{if $file.IsGenerated}}data-folded="true"{{end}}>
6161
<h4 class="diff-file-header sticky-2nd-row ui top attached normal header df ac sb">
62-
<div class="fold-file df ac">
62+
<div class="df ac">
6363
<a role="button" class="fold-file muted mr-2">
6464
{{if $file.IsGenerated}}
6565
{{svg "octicon-chevron-right" 18}}

web_src/js/features/repo-code.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,9 +131,8 @@ export function initRepoCodeView() {
131131
}
132132
$(document).on('click', '.fold-file', ({currentTarget}) => {
133133
const box = currentTarget.closest('.file-content');
134-
const chevron = currentTarget.querySelector('a.chevron');
135134
const folded = box.dataset.folded !== 'true';
136-
chevron.innerHTML = svg(`octicon-chevron-${folded ? 'right' : 'down'}`, 18);
135+
currentTarget.innerHTML = svg(`octicon-chevron-${folded ? 'right' : 'down'}`, 18);
137136
box.dataset.folded = String(folded);
138137
});
139138
$(document).on('click', '.blob-excerpt', async ({currentTarget}) => {

0 commit comments

Comments
 (0)