webhook: set Content-Type for application/x-www-form-urlencoded (#8600)

vszakats · zeripath · commit 8e9265c40298 · 2019-10-20T18:18:05.000+01:00
This header is missing since switching http client from GiteaServer (`code.gitea.io/gitea/modules/httplib`) to Go-http-client/1.1 (`net.http`). The header [was added by default](https://github.com/go-gitea/gitea/blob/release/v1.8/modules/httplib/httplib.go#L301) by the former, but this is no longer true with `net.http`, so it needs to be done explicitly. Closes: #7700
diff --git a/models/webhook.go b/models/webhook.go
@@ -833,6 +833,8 @@ func (t *HookTask) deliver() error {
 
 				return err
 			}
+
+			req.Header.Set("Content-Type", "application/x-www-form-urlencoded")
 		}
 	case http.MethodGet:
 		u, err := url.Parse(t.URL)

Original file line number	Diff line number	Diff line change
`@@ -833,6 +833,8 @@ func (t *HookTask) deliver() error {`
`833`	`833`
`834`	`834`	`return err`
`835`	`835`	`}`
	`836`	`+`
	`837`	`+ req.Header.Set("Content-Type", "application/x-www-form-urlencoded")`
`836`	`838`	`}`
`837`	`839`	`case http.MethodGet:`
`838`	`840`	`u, err := url.Parse(t.URL)`