Skip to content

Commit 9538842

Browse files
GeorgDanglGiteaBot
andauthored
Use correct response code in push mirror creation response in v1_json.tmpl (#25476)
In the process of doing a bit of automation via the API, we've discovered a _small_ issue in the Swagger definition. We tried to create a push mirror for a repository, but our generated client raised an exception due to an unexpected status code. When looking at this function: https://github.com/go-gitea/gitea/blob/3c7f5ed7b5bff347198cbb26492e6354ea42733b/routers/api/v1/repo/mirror.go#L236-L240 We see it defines `201 - Created` as response: https://github.com/go-gitea/gitea/blob/3c7f5ed7b5bff347198cbb26492e6354ea42733b/routers/api/v1/repo/mirror.go#L260-L262 But it actually returns `200 - OK`: https://github.com/go-gitea/gitea/blob/3c7f5ed7b5bff347198cbb26492e6354ea42733b/routers/api/v1/repo/mirror.go#L373 So I've just updated the Swagger definitions to match the code😀 --------- Co-authored-by: Giteabot <[email protected]>
1 parent b4d0036 commit 9538842

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

routers/api/v1/repo/mirror.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ func AddPushMirror(ctx *context.APIContext) {
258258
// schema:
259259
// "$ref": "#/definitions/CreatePushMirrorOption"
260260
// responses:
261-
// "201":
261+
// "200":
262262
// "$ref": "#/responses/PushMirror"
263263
// "403":
264264
// "$ref": "#/responses/forbidden"

templates/swagger/v1_json.tmpl

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)