Skip to content

Commit 95c3dc8

Browse files
lafrikslafriks
authored
Fix max length check and limit in multiple repo forms (#9148)
* Fix input field max length for release, label and milestone forms * Add max length for isseu and PR title
1 parent e8241bf commit 95c3dc8

File tree

6 files changed

+15
-15
lines changed

6 files changed

+15
-15
lines changed

‎modules/auth/repo_form.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -507,9 +507,9 @@ func (f SubmitReviewForm) HasEmptyContent() bool {
507507

508508
// NewReleaseForm form for creating release
509509
type NewReleaseForm struct {
510-
TagName string `binding:"Required;GitRefName"`
511-
Target string `form:"tag_target" binding:"Required"`
512-
Title string `binding:"Required"`
510+
TagName string `binding:"Required;GitRefName;MaxSize(255)"`
511+
Target string `form:"tag_target" binding:"Required;MaxSize(255)"`
512+
Title string `binding:"Required;MaxSize(255)"`
513513
Content string
514514
Draft string
515515
Prerelease bool
@@ -523,7 +523,7 @@ func (f *NewReleaseForm) Validate(ctx *macaron.Context, errs binding.Errors) bin
523523

524524
// EditReleaseForm form for changing release
525525
type EditReleaseForm struct {
526-
Title string `form:"title" binding:"Required"`
526+
Title string `form:"title" binding:"Required;MaxSize(255)"`
527527
Content string `form:"content"`
528528
Draft string `form:"draft"`
529529
Prerelease bool `form:"prerelease"`

‎templates/repo/issue/labels.tmpl

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,16 +17,16 @@
1717
<div class="ui grid">
1818
<div class="three wide column">
1919
<div class="ui small input">
20-
<input class="new-label-input emoji-input" name="title" placeholder="{{.i18n.Tr "repo.issues.new_label_placeholder"}}" autofocus required>
20+
<input class="new-label-input emoji-input" name="title" placeholder="{{.i18n.Tr "repo.issues.new_label_placeholder"}}" autofocus required maxlength="50">
2121
</div>
2222
</div>
2323
<div class="five wide column">
2424
<div class="ui small fluid input">
25-
<input class="new-label-desc-input" name="description" placeholder="{{.i18n.Tr "repo.issues.new_label_desc_placeholder"}}">
25+
<input class="new-label-desc-input" name="description" placeholder="{{.i18n.Tr "repo.issues.new_label_desc_placeholder"}}" maxlength="200">
2626
</div>
2727
</div>
2828
<div class="color picker column">
29-
<input class="color-picker" name="color" value="#70c24a" required>
29+
<input class="color-picker" name="color" value="#70c24a" required maxlength="7">
3030
</div>
3131
<div class="column precolors">
3232
{{template "repo/issue/label_precolors"}}
@@ -151,16 +151,16 @@
151151
<div class="ui grid">
152152
<div class="three wide column">
153153
<div class="ui small input">
154-
<input class="new-label-input emoji-input" name="title" placeholder="{{.i18n.Tr "repo.issues.new_label_placeholder"}}" autofocus required>
154+
<input class="new-label-input emoji-input" name="title" placeholder="{{.i18n.Tr "repo.issues.new_label_placeholder"}}" autofocus required maxlength="50">
155155
</div>
156156
</div>
157157
<div class="five wide column">
158158
<div class="ui small fluid input">
159-
<input class="new-label-desc-input" name="description" placeholder="{{.i18n.Tr "repo.issues.new_label_desc_placeholder"}}">
159+
<input class="new-label-desc-input" name="description" placeholder="{{.i18n.Tr "repo.issues.new_label_desc_placeholder"}}" maxlength="200">
160160
</div>
161161
</div>
162162
<div class="color picker column">
163-
<input class="color-picker" name="color" value="#70c24a" required>
163+
<input class="color-picker" name="color" value="#70c24a" required maxlength="7">
164164
</div>
165165
<div class="column precolors">
166166
{{template "repo/issue/label_precolors"}}

‎templates/repo/issue/milestone_new.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
<div class="eleven wide column">
2727
<div class="field {{if .Err_Title}}error{{end}}">
2828
<label>{{.i18n.Tr "repo.milestones.title"}}</label>
29-
<input name="title" placeholder="{{.i18n.Tr "repo.milestones.title"}}" value="{{.title}}" autofocus required>
29+
<input name="title" placeholder="{{.i18n.Tr "repo.milestones.title"}}" value="{{.title}}" autofocus required maxlength="50">
3030
</div>
3131
<div class="field">
3232
<label>{{.i18n.Tr "repo.milestones.desc"}}</label>

‎templates/repo/issue/new_form.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
</a>
1414
<div class="ui segment content">
1515
<div class="field">
16-
<input name="title" id="issue_title" placeholder="{{.i18n.Tr "repo.milestones.title"}}" value="{{.title}}" tabindex="3" autofocus required>
16+
<input name="title" id="issue_title" placeholder="{{.i18n.Tr "repo.milestones.title"}}" value="{{.title}}" tabindex="3" autofocus required maxlength="255">
1717
{{if .PageIsComparePull}}
1818
<div class="title_wip_desc">{{.i18n.Tr "repo.pulls.title_wip_desc" (index .PullRequestWorkInProgressPrefixes 0| Escape) | Safe}}</div>
1919
{{end}}

‎templates/repo/issue/view_title.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<h1 class="twelve wide column">
44
<span class="index">#{{.Issue.Index}}</span> <span id="issue-title" class="has-emoji">{{.Issue.Title}}</span>
55
<div id="edit-title-input" class="ui input" style="display: none">
6-
<input value="{{.Issue.Title}}">
6+
<input value="{{.Issue.Title}}" maxlength="255">
77
</div>
88
</h1>
99
{{if and (or .IsIssueWriter .IsIssuePoster) (not .Repository.IsArchived)}}

‎templates/repo/release/new.tmpl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
{{if .PageIsEditRelease}}
2020
<b>{{.tag_name}}</b><span class="at">@</span><strong>{{.tag_target}}</strong>
2121
{{else}}
22-
<input id="tag-name" name="tag_name" value="{{.tag_name}}" placeholder="{{.i18n.Tr "repo.release.tag_name"}}" autofocus required>
22+
<input id="tag-name" name="tag_name" value="{{.tag_name}}" placeholder="{{.i18n.Tr "repo.release.tag_name"}}" autofocus required maxlength="255">
2323
<span class="at">@</span>
2424
<div class="ui selection dropdown">
2525
<input type="hidden" name="tag_target" value="{{.tag_target}}"/>
@@ -42,7 +42,7 @@
4242
<div class="eleven wide column">
4343
<div class="field {{if .Err_Title}}error{{end}}">
4444
<label>{{.i18n.Tr "repo.release.title"}}</label>
45-
<input name="title" placeholder="{{.i18n.Tr "repo.release.title"}}" value="{{.title}}" autofocus required>
45+
<input name="title" placeholder="{{.i18n.Tr "repo.release.title"}}" value="{{.title}}" autofocus required maxlength="255">
4646
</div>
4747
<div class="field">
4848
<label>{{.i18n.Tr "repo.release.content"}}</label>

0 commit comments

Comments
 (0)