Fix incorrect rendering csv file when file size is larger than UI.CSV.MaxFileSize (#29653)

yp05327 · web-flow · commit 9dc8a6336edd · 2024-03-08T08:44:50.000Z
Fix #29506
diff --git a/modules/markup/csv/csv.go b/modules/markup/csv/csv.go
@@ -93,8 +93,10 @@ func (Renderer) Render(ctx *markup.RenderContext, input io.Reader, output io.Wri
 		if _, err := tmpBlock.WriteString(html.EscapeString(string(rawBytes))); err != nil {
 			return err
 		}
-		_, err = tmpBlock.WriteString("</pre>")
-		return err
+		if _, err := tmpBlock.WriteString("</pre>"); err != nil {
+			return err
+		}
+		return tmpBlock.Flush()
 	}
 
 	rd, err := csv.CreateReaderAndDetermineDelimiter(ctx, bytes.NewReader(rawBytes))

Original file line number	Diff line number	Diff line change
`@@ -93,8 +93,10 @@ func (Renderer) Render(ctx *markup.RenderContext, input io.Reader, output io.Wri`
`93`	`93`	`if _, err := tmpBlock.WriteString(html.EscapeString(string(rawBytes))); err != nil {`
`94`	`94`	`return err`
`95`	`95`	`}`
`96`		`- _, err = tmpBlock.WriteString("</pre>")`
`97`		`- return err`
	`96`	`+ if _, err := tmpBlock.WriteString("</pre>"); err != nil {`
	`97`	`+ return err`
	`98`	`+ }`
	`99`	`+ return tmpBlock.Flush()`
`98`	`100`	`}`
`99`	`101`
`100`	`102`	`rd, err := csv.CreateReaderAndDetermineDelimiter(ctx, bytes.NewReader(rawBytes))`