Fix problem when self-assign notification (#18797) (#18976)

fnetX · lunny · web-flow · commit a3f72303d1ff · 2022-03-02T20:11:55.000Z
Co-authored-by: Lunny Xiao &lt;xiaolunwen@gmail.com&gt;
diff --git a/modules/notification/ui/ui.go b/modules/notification/ui/ui.go
@@ -204,7 +204,7 @@ func (ns *notificationService) NotifyPullRevieweDismiss(doer *user_model.User, r
 }
 
 func (ns *notificationService) NotifyIssueChangeAssignee(doer *user_model.User, issue *models.Issue, assignee *user_model.User, removed bool, comment *models.Comment) {
-	if !removed {
+	if !removed && doer.ID != assignee.ID {
 		var opts = issueNotificationOpts{
 			IssueID:              issue.ID,
 			NotificationAuthorID: doer.ID,

Original file line number	Diff line number	Diff line change
`@@ -204,7 +204,7 @@ func (ns notificationService) NotifyPullRevieweDismiss(doer user_model.User, r`
`204`	`204`	`}`
`205`	`205`
`206`	`206`	`func (ns notificationService) NotifyIssueChangeAssignee(doer user_model.User, issue models.Issue, assignee user_model.User, removed bool, comment *models.Comment) {`
`207`		`- if !removed {`
	`207`	`+ if !removed && doer.ID != assignee.ID {`
`208`	`208`	`var opts = issueNotificationOpts{`
`209`	`209`	`IssueID: issue.ID,`
`210`	`210`	`NotificationAuthorID: doer.ID,`