Skip to content

Commit a92f505

Browse files
authored
Fix and/or comment some legacy CSS problems (#33015)
1 parent 3d3ece3 commit a92f505

File tree

6 files changed

+13
-27
lines changed

6 files changed

+13
-27
lines changed

templates/repo/branch/list.tmpl

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,8 @@
2929
</div>
3030
<p class="info tw-flex tw-items-center tw-my-1">{{svg "octicon-git-commit" 16 "tw-mr-1"}}<a href="{{.RepoLink}}/commit/{{PathEscape .DefaultBranchBranch.DBBranch.CommitID}}">{{ShortSha .DefaultBranchBranch.DBBranch.CommitID}}</a> · <span class="commit-message">{{ctx.RenderUtils.RenderCommitMessage .DefaultBranchBranch.DBBranch.CommitMessage (.Repository.ComposeMetas ctx)}}</span> · {{ctx.Locale.Tr "org.repo_updated"}} {{DateUtils.TimeSince .DefaultBranchBranch.DBBranch.CommitTime}}{{if .DefaultBranchBranch.DBBranch.Pusher}} &nbsp;{{template "shared/user/avatarlink" dict "user" .DefaultBranchBranch.DBBranch.Pusher}}{{template "shared/user/namelink" .DefaultBranchBranch.DBBranch.Pusher}}{{end}}</p>
3131
</td>
32-
<td class="right aligned middle aligned overflow-visible">
32+
{{/* FIXME: here and below, the tw-overflow-visible is not quite right but it is still needed the moment: to show the important buttons when the width is narrow */}}
33+
<td class="right aligned middle aligned tw-overflow-visible">
3334
{{if and $.IsWriter (not $.Repository.IsArchived) (not .IsDeleted)}}
3435
<button class="btn interact-bg show-create-branch-modal tw-p-2"
3536
data-modal="#create-branch-modal"
@@ -148,7 +149,8 @@
148149
{{end}}
149150
{{end}}
150151
</td>
151-
<td class="three wide right aligned overflow-visible">
152+
{{/* FIXME: here and above, the tw-overflow-visible is not quite right */}}
153+
<td class="three wide right aligned tw-overflow-visible">
152154
{{if and $.IsWriter (not $.Repository.IsArchived) (not .DBBranch.IsDeleted)}}
153155
<button class="btn interact-bg tw-p-2 show-modal show-create-branch-modal"
154156
data-branch-from="{{.DBBranch.Name}}"

templates/repo/settings/options.tmpl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -733,7 +733,7 @@
733733
<span class="field">
734734
{{if .CodeIndexerStatus}}
735735
<a rel="nofollow" class="ui sha label" href="{{.RepoLink}}/commit/{{.CodeIndexerStatus.CommitSha}}">
736-
<span class="shortsha">{{ShortSha .CodeIndexerStatus.CommitSha}}</span>
736+
{{ShortSha .CodeIndexerStatus.CommitSha}}
737737
</a>
738738
{{else}}
739739
<span>{{ctx.Locale.Tr "repo.settings.admin_indexer_unindexed"}}</span>
@@ -752,7 +752,7 @@
752752
<span class="field">
753753
{{if and .StatsIndexerStatus .StatsIndexerStatus.CommitSha}}
754754
<a rel="nofollow" class="ui sha label" href="{{.RepoLink}}/commit/{{.StatsIndexerStatus.CommitSha}}">
755-
<span class="shortsha">{{ShortSha .StatsIndexerStatus.CommitSha}}</span>
755+
{{ShortSha .StatsIndexerStatus.CommitSha}}
756756
</a>
757757
{{else}}
758758
<span>{{ctx.Locale.Tr "repo.settings.admin_indexer_unindexed"}}</span>

web_src/css/base.css

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -928,7 +928,8 @@ strong.attention-caution, svg.attention-caution {
928928
color: var(--color-red-dark-1);
929929
}
930930

931-
.center:not(.popup) {
931+
/* FIXME: this is a longstanding dirty patch since 2015, it only makes the pages more messy and shouldn't be used */
932+
.center {
932933
text-align: center;
933934
}
934935

web_src/css/explore.css

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,4 @@
1-
.explore .secondary-nav {
2-
border-width: 1px !important;
3-
}
4-
5-
.explore .secondary-nav .svg {
6-
width: 16px;
7-
text-align: center;
8-
margin-right: 5px;
9-
}
10-
1+
/* FIXME: need to refactor the repo branches list page and move these styles to proper place */
112
.ui.repository.branches .info {
123
font-size: 12px;
134
color: var(--color-text-light);
@@ -20,12 +11,3 @@
2011
overflow: hidden;
2112
text-overflow: ellipsis;
2213
}
23-
24-
.ui.repository.branches .overflow-visible {
25-
overflow: visible;
26-
}
27-
28-
/* fix alignment of PR popup in branches table */
29-
.ui.repository.branches table .ui.popup {
30-
text-align: left;
31-
}

web_src/css/index.css

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,5 +82,6 @@
8282
@import "./review.css";
8383
@import "./actions.css";
8484

85-
@tailwind utilities;
8685
@import "./helpers.css";
86+
87+
@tailwind utilities;

web_src/css/modules/navbar.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,11 +103,11 @@
103103
#navbar .ui.dropdown .navbar-profile-admin {
104104
display: block;
105105
position: absolute;
106-
font-size: 10px;
106+
font-size: 9px;
107107
font-weight: var(--font-weight-bold);
108108
color: var(--color-nav-bg);
109109
background: var(--color-primary);
110-
padding: 2px 4px;
110+
padding: 2px 3px;
111111
border-radius: 10px;
112112
top: -1px;
113113
left: 18px;

0 commit comments

Comments
 (0)